Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expiry information for names #1924

Merged
merged 7 commits into from Nov 20, 2019
Merged

Conversation

@friedger
Copy link
Contributor

friedger commented May 28, 2019

This PR

  • adds information about name expiry in the list of all user names (AllProfilesPage)
  • helps to solve #1079

Screenshot from 2019-05-28 13-14-37

  • fixes also transfer name and update zone file page
    Screenshot from 2019-06-05 23-41-02
@markmhx markmhx requested a review from hstove Jun 4, 2019
@markmhx markmhx added the enhancement label Jun 4, 2019
@jeffdomke

This comment has been minimized.

Copy link
Member

jeffdomke commented Jun 11, 2019

Bit of background on how many names were registered each month and thus how many will expire 2 years later:

date count
2017-06 432
2017-07 354
2017-08 233
2017-09 482
2017-10 5308
2017-11 248
2017-12 85
2018-01 138
2018-02 438
2018-03 906
2018-04 354
2018-05 437
2018-06 122
2018-07 107
2018-08 31
2018-09 9
2018-10 81
2018-11 17
2019-01 26
2019-02 47
2019-03 49
2019-04 54
2019-05 17

In Oct it will be 4x the IDs that expire.

@markmhx

This comment has been minimized.

Copy link

markmhx commented Jul 2, 2019

@yknl has created PR #1938 that includes all the changes in this PR. We'll keep this PR open until the other is completed and merged.

@yknl yknl mentioned this pull request Aug 30, 2019
@jeffdomke jeffdomke added this to the DX Q4 Sprint 1 milestone Oct 3, 2019
@hstove hstove modified the milestones: DX Q4 Sprint 1, Browser 0.37 Nov 12, 2019
@hstove hstove merged commit ea86a15 into blockstack:develop Nov 20, 2019
4 of 7 checks passed
4 of 7 checks passed
ci/circleci: test-e2e-account-creation Your tests failed on CircleCI
Details
ci/circleci: test-e2e-login Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-account-recovery Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.