Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error messages for the type checker #944

Closed
kantai opened this issue May 7, 2019 · 2 comments

Comments

@kantai
Copy link
Member

commented May 7, 2019

There's a number of ways that the type checker errors can be improved (so this may be more appropriately an epic).

  1. Line numbers, rather than subexpressions.
  2. More descriptive error messages, especially when it comes to arg-counts. Things like (define ...) (let ...) and (tuple ...) expressions are a little more complex to reason about the argument number.
@kantai kantai added the clarity label Jun 4, 2019
@kantai

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2019

@lgalabru is investigating implementing by transporting a "diagnostic" object:

e.g.,

https://github.com/rust-lang/rust/blob/d3e2cec29225a46298ec4ebf082f34ebd7cfeecf/src/librustc_errors/diagnostic.rs#L13

This is starting to roughly standardize across IDEs, and can lead to useful error checks.

For an exciting preview:

Screen Shot 2019-06-27 at 9.58.46 AM.png

@lgalabru lgalabru self-assigned this Jun 27, 2019
@lgalabru

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

Handled with #1041

@lgalabru lgalabru closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.