Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require strict function ordering #985

Closed
zone117x opened this issue May 30, 2019 · 4 comments

Comments

@zone117x
Copy link
Member

commented May 30, 2019

Top level function definition ordering is unnecessarily strict. The type checker will report a function as undefined if it is invoked before its declaration.

@jcnelson

This comment has been minimized.

Copy link
Member

commented May 30, 2019

What's wrong with that?

@kantai kantai added the clarity label Jun 4, 2019
@lgalabru

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

I was also surprised by this.
I personally don't have a strong opinion about it, however if we're not considering working on this constraint (cc @kantai), we should definitely document it (cc @moxiegirl).

@kantai

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

I think we should fix this --- almost no modern compilers will complain about this kind of ordering.

@lgalabru

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Handled with #1079

@lgalabru lgalabru closed this Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.