Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval command should be expecting contract-id #1144

Merged
merged 3 commits into from Nov 1, 2019

Conversation

@lgalabru
Copy link
Member

lgalabru commented Oct 30, 2019

This PR is addressing an issue raised by @moxiegirl, where the eval command is expecting a contract-name instead of a contract-id.

…ransients
@lgalabru lgalabru requested review from jcnelson and kantai Oct 30, 2019
@lgalabru lgalabru changed the title Eval command should be loading fully qualified contracts Eval command should be expecting contract-id Oct 30, 2019
@moxiegirl moxiegirl added chore Impacts DOCS and removed chore labels Oct 30, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #1144 into develop will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1144      +/-   ##
===========================================
+ Coverage    79.64%   79.69%   +0.05%     
===========================================
  Files          133      133              
  Lines        27765    27848      +83     
===========================================
+ Hits         22113    22194      +81     
- Misses        5652     5654       +2
Impacted Files Coverage Δ
src/clarity.rs 45.51% <0%> (+0.3%) ⬆️
src/net/prune.rs 72% <0%> (-1.34%) ⬇️
src/vm/database/mod.rs 100% <0%> (ø) ⬆️
src/vm/tests/forking.rs 97.14% <0%> (ø) ⬆️
src/vm/types/serialization.rs 98.55% <0%> (ø) ⬆️
src/net/chat.rs 84.16% <0%> (+0.01%) ⬆️
src/vm/analysis/definition_sorter/mod.rs 97.26% <0%> (+0.01%) ⬆️
src/vm/analysis/read_only_checker/mod.rs 97.91% <0%> (+0.02%) ⬆️
src/vm/analysis/analysis_db.rs 94.73% <0%> (+0.07%) ⬆️
src/vm/database/marf.rs 86.79% <0%> (+0.12%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7d74a...e73b68f. Read the comment docs.

@lgalabru lgalabru self-assigned this Oct 30, 2019
@kantai
kantai approved these changes Oct 31, 2019
Copy link
Member

kantai left a comment

Looks good to me!

@moxiegirl

This comment has been minimized.

Copy link
Contributor

moxiegirl commented Nov 1, 2019

@lgalabru @kantai Can we move this one to merge? I am blocked updating the Clarity smart contract docs on this fix.

@lgalabru lgalabru merged commit b86998c into develop Nov 1, 2019
5 of 6 checks passed
5 of 6 checks passed
codecov/patch 0% of diff hit (target 79.64%)
Details
ci/circleci: cargo_tests Your tests passed on CircleCI!
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: test_demo Your tests passed on CircleCI!
Details
codecov/project 79.69% (+0.05%) compared to cd7d74a
Details
license/cla Contributor License Agreement is signed.
Details
@lgalabru lgalabru deleted the fix/eval-command branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.