Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relevant fixes for q4 sprint #177

Merged
merged 34 commits into from Nov 13, 2019
Merged

Relevant fixes for q4 sprint #177

merged 34 commits into from Nov 13, 2019

Conversation

@hstove
Copy link
Collaborator

hstove commented Nov 6, 2019

This PR contains front-end changes related to this milestone:

https://app.zenhub.com/workspaces/blockstack-engineering-582a2234b399ebbf18315399/board?milestones=Q4-%20Explorer%20Sprint%201%23&filterLogic=any&repos=180429576,56251702&showEstimates=false&showPipelineDescriptions=false

  • Fixing the API_URL that is used for integration tests (the URL recently changed)
  • Better display of numbers in the "Address card" on the STX address page
    • Show totals that are calculated on the API server, instead of duplicating some logic and math
    • Show "Token grants" if this investor was an app miner in the 2019 hard fork, where they got tokens with no vesting
    • The "Available Balance" now uses a new calculated number instead of the balance that the Core API provides

Notes for reviewers

This is a mostly straightforward next.js server. All data is fetched from the API server, and the responsibility of this app is strictly UI, with some light utilities for things like formatting numbers and dates.

Install dependencies with yarn. Run the app with yarn dev.

By default, the app points to the staging API server, to make front-end dev easier. You may wish to use this at first, if you're waiting on seeding your DB on the API. Eventually, to point your local app to the local API, you can create a .env file with only one line:

API_URL=http://localhost:4000

You'll have to restart your server to apply the change.

timstackblock and others added 9 commits Oct 16, 2019
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/jonschlinkert/mixin-deep/releases)
- [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [open](https://github.com/sindresorhus/open) from 0.0.5 to 6.0.0.
- [Release notes](https://github.com/sindresorhus/open/releases)
- [Commits](https://github.com/sindresorhus/open/commits/v6.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.12.0 to 3.13.1.
- [Release notes](https://github.com/nodeca/js-yaml/releases)
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@3.12.0...3.13.1)

Signed-off-by: dependabot[bot] <support@github.com>
@jeffdomke jeffdomke added this to the Q4- Explorer Sprint 1 milestone Nov 6, 2019
timstackblock and others added 5 commits Nov 7, 2019
@hstove hstove requested review from reedrosenbluth and zone117x Nov 7, 2019
hstove and others added 11 commits Nov 7, 2019
…-deep-1.3.2

Bump mixin-deep from 1.3.1 to 1.3.2
…ml-3.13.1

Bump js-yaml from 3.12.0 to 3.13.1
…ity-develop/open-6.0.0

Bump open from 0.0.5 to 6.0.0 in /serenity-develop
Copy link
Member

zone117x left a comment

Issue #176 appears to be fixed when viewing that same address in latest local dev env

hstove added 3 commits Nov 8, 2019
@@ -2,7 +2,7 @@ import numeral from 'numeral';

export const formatValue = (v) => {
const number = parseFloat(v);
return number >= 1000 ? numeral(number).format('0,0.[000000]') : number;
return number >= 1000 ? numeral(number).format('0,0.[000]') : number;

This comment has been minimized.

Copy link
@zone117x

zone117x Nov 8, 2019

Member

I think these should always use the full STX value, down to the smallest unit. We should also use bigint since the js floating point accuracy can cause issues.

This comment has been minimized.

Copy link
@hstove

hstove Nov 8, 2019

Author Collaborator

Sorry, this was specifically requested by Muneeb to show less precision for big numbers.

This comment has been minimized.

Copy link
@zone117x

zone117x Nov 8, 2019

Member

I argue otherwise in the issue #182

hstove and others added 5 commits Nov 9, 2019
New tests for using search
Copy link
Member

zone117x left a comment

The referenced issues appear to be fixed. The code de-duplication looks good.

Left a comment about STX rounding, doesn't need to block this PR.

Copy link

reedrosenbluth left a comment

LGTM!

@hstove hstove merged commit 1f91a13 into master Nov 13, 2019
1 check passed
1 check passed
ci/circleci: test Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.