Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude unused bip39 wordlists from dist bundle #683

Merged
merged 3 commits into from Aug 23, 2019

Conversation

@zone117x
Copy link
Member

commented Jul 31, 2019

Reduce blockstack.js dist bundle size #582

Exclude unused bip39 wordlists from dist bundle. Removes around 240KB (uncompressed) of data.

image

Acceptance criteria:

  • Ensure the dist/blockstack.js bundle still works normally in web apps -- that is the only file this PR changes.
…ncompressed)
@zone117x zone117x requested review from hstove and yknl Jul 31, 2019
@codecov

This comment has been minimized.

Copy link

commented Jul 31, 2019

Codecov Report

Merging #683 into feature/update-jsontokens will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feature/update-jsontokens     #683   +/-   ##
==========================================================
  Coverage                      75.34%   75.34%           
==========================================================
  Files                             57       57           
  Lines                           2867     2867           
  Branches                         220      220           
==========================================================
  Hits                            2160     2160           
  Misses                           679      679           
  Partials                          28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc400d1...71e2bf4. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jul 31, 2019

Codecov Report

Merging #683 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #683   +/-   ##
========================================
  Coverage    75.34%   75.34%           
========================================
  Files           57       57           
  Lines         2868     2868           
  Branches       220      220           
========================================
  Hits          2161     2161           
  Misses         679      679           
  Partials        28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb07af...7aaa82e. Read the comment docs.

webpack.config.js Outdated Show resolved Hide resolved
@jeffdomke jeffdomke added this to the DX Q3 1 milestone Aug 7, 2019
@zone117x zone117x self-assigned this Aug 9, 2019
@jeffdomke jeffdomke requested review from timstackblock and removed request for hstove Aug 9, 2019
@zone117x

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

TODO: Test out another regex example for excluding all but english worldlists

@timstackblock timstackblock removed their request for review Aug 14, 2019
* develop:
  Fix typedoc build
  Disable synthetic default es6 module import code gen -- likely fix for  #681
  Remove extra console log from tests.
  Bump to v19.2.5.
  Bump to v19.2.4 and include script-dist-file.md
  Bump to version 19.2.3.
  Throw error on user session overwrite.
@zone117x zone117x changed the base branch from feature/update-jsontokens to develop Aug 21, 2019
@zone117x

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

@yknl Updated the PR with the single regex filter you suggested -- it works. Thanks!

@yknl
yknl approved these changes Aug 23, 2019
Copy link
Collaborator

left a comment

LGTM

@zone117x

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2019

Going to merge this since this only changes the dist bundle.

@zone117x zone117x merged commit 249ad21 into develop Aug 23, 2019
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 75.34% remains the same compared to 9cb07af
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.