Skip to content
This repository has been archived by the owner. It is now read-only.

Close modal when clicking outside of it or hitting escape key #51

Closed
markmhx opened this issue Feb 17, 2020 · 2 comments
Closed

Close modal when clicking outside of it or hitting escape key #51

markmhx opened this issue Feb 17, 2020 · 2 comments
Assignees
Labels

Comments

@markmhx
Copy link

@markmhx markmhx commented Feb 17, 2020

Screen Shot 2020-02-17 at 11.13.48.png

@markmhx markmhx added the enhancement label Feb 17, 2020
@whoabuddy

This comment has been minimized.

Copy link

@whoabuddy whoabuddy commented Feb 20, 2020

FYI clicking outside the modal works for me in Vivaldi 2.11.1811.38 (Stable channel) (64-bit) on Linux Mint. Hitting esc does not.

However, in doing so the button still displays Loading..., and clicking on it still pulls up the modal as expected.

2 2020-02-19 14 19 30 banter pub 6928fccf8a46

@kyranjamie kyranjamie self-assigned this Feb 20, 2020
kyranjamie added a commit to blockstack/ui that referenced this issue Feb 20, 2020
@markmhx

This comment has been minimized.

Copy link
Author

@markmhx markmhx commented Feb 21, 2020

@whoabuddy Thanks for the Banter report. @hstove can we have Banter show "Get started" again if the user bails from onboarding before completion (from modal display onwards)?

@markmhx markmhx closed this Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.