Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: authentication/connect was removed #893

Merged
merged 1 commit into from Nov 23, 2020

Conversation

friedger
Copy link
Collaborator

@friedger friedger commented Nov 8, 2020

Description

See "Removed connect page is still referenced" #892 for details.

This PR

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Checklist

@vercel
Copy link

vercel bot commented Nov 8, 2020

@friedger is attempting to deploy a commit to the Blockstack Team on Vercel.

A member of the Team first needs to authorize it.

src/pages/build-an-app.md Outdated Show resolved Hide resolved
next.config.js Show resolved Hide resolved
@agraebe agraebe requested review from yknl and hstove November 9, 2020 16:32
@friedger
Copy link
Collaborator Author

@agraebe comments addressed and squashed

@hstove
Copy link
Contributor

hstove commented Nov 10, 2020

Wait, Connect docs were removed? 😢

If you visit https://blockstack.github.io/stacks.js, there are no docs for using connect, or authentication. Clicking @stacks/auth is a 404. Definitely not ready to merge yet

@agraebe
Copy link
Contributor

agraebe commented Nov 10, 2020

If you visit https://blockstack.github.io/stacks.js, there are no docs for using connect, or authentication. Clicking @stacks/auth is a 404. Definitely not ready to merge yet

seems like all the links in the list 404. @yknl could you chime in to help resolve? thanks!

@yknl
Copy link
Collaborator

yknl commented Nov 10, 2020

Wait, Connect docs were removed?

Only the connect specific page was removed. Since a lot of the content is already in the tutorial and we no longer reference connect directly.

seems like all the links in the list 404. @yknl could you chime in to help resolve? thanks!

It's showing the readme file from the project root, which if you access from github will correctly link to the packages. They're relative links but we can update to absolute URLs.

@agraebe
Copy link
Contributor

agraebe commented Nov 10, 2020

It's showing the readme file from the project root, which if you access from github will correctly link to the packages. They're relative links but we can update to absolute URLs.

yeah let's update. I think most would assume the links are broken otherwise

@friedger
Copy link
Collaborator Author

The links on github for stacks.js has been fixed. Can this PR be merged now?

@agraebe agraebe self-requested a review November 23, 2020 19:43
Copy link
Contributor

@agraebe agraebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@agraebe agraebe merged commit 4196aff into stacks-network:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removed connect page is still referenced
4 participants