Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage driver for IPFS #438

Merged
merged 3 commits into from Sep 29, 2018
Merged

Conversation

sunnya97
Copy link

@sunnya97 sunnya97 commented May 27, 2017

Proposed storage driver for IPFS in response to #430

Before using, you will need to use pip to install ipfsapi.
You will also need a local running instance of IPFS.

Uses the ipfs MFS for mutable files.

@sunnya97
Copy link
Author

sunnya97 commented May 27, 2017

@jcnelson In IPFS there is no way to actually delete data from the network once published, especially for the immutable data (for mutable you can delete the pointer to it).

Are you suggesting that we should design the driver in such a way that Blockstack thinks that data is deleted but in reality is still reachable by the underlying IPFS?

@jcnelson
Copy link
Member

Thank you for your submission! I'll take a look today.

Are you suggesting that we should design the driver in such a way that Blockstack thinks that data is deleted but in reality is still reachable by the underlying IPFS?

Yes, this is sufficient.

@sunnya97
Copy link
Author

@jcnelson Checking in for an update on this. Thanks!

@jcnelson
Copy link
Member

Hey @sunnya97, sorry this got away from us. So far it looks good! I'll take a look at it tonight and let @shea256 and @muneeb-ali know.

@jcnelson
Copy link
Member

Hey @sunnya97, I ran the tests described in the issue. I'm not sure why this is happening. Maybe you can shed some light?

$ ./blockstack-storage-driver-test --debug --index --config /tmp/client.ini --datasets /tmp/test-datasets.json blockstack_client.backend.drivers.ipfs put
[2017-07-22 02:28:50,986] [DEBUG] [spv:103] (19911.140670391622472) Using mainnet
[2017-07-22 02:28:51,088] [DEBUG] [ecdsalib:225] (19911.140670391622472) High-S to low-S
[2017-07-22 02:28:51,090] [DEBUG] [ecdsalib:225] (19911.140670391622472) High-S to low-S
[2017-07-22 02:28:51,092] [DEBUG] [ecdsalib:225] (19911.140670391622472) High-S to low-S
[2017-07-22 02:28:51,094] [DEBUG] [ecdsalib:225] (19911.140670391622472) High-S to low-S
[2017-07-22 02:28:51,100] [DEBUG] [ecdsalib:225] (19911.140670391622472) High-S to low-S
[2017-07-22 02:28:51,105] [DEBUG] [ecdsalib:225] (19911.140670391622472) High-S to low-S
Testing put_immutable_handler...
   Put immutable 'my_first_datum' (d7d5ee7824ff93f94c3055af9382c86c68b5ca92)
   Put immutable '/my/second/datum' (69d832d23a020c64ba0b44646e87ec657b4aaf43)
   Put immutable 'user"_profile' (d873f6782d27d6c8964023f26709580cb68b02aa)
   Put immutable 'zonefile' (4d718e536b57c2dcc556cf2cdbadf1b6647ead80)
   Put immutable 'empty string' (b472a266d0bd89c13706a4132ccfb16f7c3b9fcb)
Testing put_mutable_handler...
   Put mutable 'my_first_datum' (d7d5ee7824ff93f94c3055af9382c86c68b5ca92)
   Put mutable '/my/second/datum' (69d832d23a020c64ba0b44646e87ec657b4aaf43)
Traceback (most recent call last):
  File "./blockstack-storage-driver-test", line 421, in <module>
    main(sys.argv)
  File "./blockstack-storage-driver-test", line 398, in main
    test_puts(driver_mod, datasets)
  File "./blockstack-storage-driver-test", line 282, in test_puts
    test_put_mutable_handler(driver_mod, dataset)
  File "./blockstack-storage-driver-test", line 74, in test_put_mutable_handler
    assert res
AssertionError

My IPFS daemon is running. It's output is:

$ ipfs daemon
Initializing daemon...
Adjusting current ulimit to 2048...
Successfully raised file descriptor limit to 2048.
Swarm listening on /ip4/127.0.0.1/tcp/4001
Swarm listening on /ip4/192.168.1.103/tcp/4001
Swarm listening on /ip4/69.244.41.25/tcp/4001
Swarm listening on /ip6/::1/tcp/4001
API server listening on /ip4/127.0.0.1/tcp/5001
Gateway (readonly) server listening on /ip4/127.0.0.1/tcp/8080
Daemon is ready
02:28:52.765 ERROR commands/h: err: multipart: NextPart: EOF handler.go:288

@kantai kantai closed this Aug 13, 2017
@kantai kantai reopened this Aug 13, 2017
@jcnelson jcnelson merged commit e1884e0 into stacks-network:rc-0.14.2 Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants