build: improvements around extension packaging #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy previewsDeploy previews for blockstack-app and blockstack-test-app are ready! Built with commit d176726. |
hstove
force-pushed
the
feat/web-ext-cli
branch
from
4292ff4
to
ce4ce83
Compare
hstove
force-pushed
the
feat/web-ext-cli
branch
from
f44bef0
to
b332606
Compare
CharlieC3
reviewed
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a bunch of small improvements around the extension build process:
.xpifile) in Github Actionsbuild-ext.shscript to create the zip file in the repository root by default, with the option to set the destination. I did this because the Dockerfile requires the file to be at the root level. I could be getting this wrong - would love a second check here.connect-extension.zip