Fix query parameter OpenAPI generation #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
blomqma
force-pushed
the
query-params-fix
branch
2 times, most recently
from
fec5ee0
to
26c714d
Compare
blomqma
force-pushed
the
query-params-fix
branch
from
7321e82
to
fec5ee0
Compare
blomqma
changed the title
blomqma
force-pushed
the
query-params-fix
branch
from
26c714d
to
1928a39
Compare
blomqma
force-pushed
the
query-params-fix
branch
from
1928a39
to
f0e57fb
Compare
blomqma
force-pushed
the
query-params-fix
branch
from
f0e57fb
to
ae4622c
Compare
The OpenAPI spec generation for query parameters ended up adding unnecessary union types for the generated schema which is fixed here. The query parameter parsing is now done with the `qs` library instead of the previous manual parsing and some test coverage is added to handle both valid and invalid query parameter calls. Co-authored-by: itsjxck <1731116+itsjxck@users.noreply.github.com>
blomqma
force-pushed
the
query-params-fix
branch
from
ae4622c
to
f774395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenAPI spec generation for query
parameters ended up adding unnecessary
union types for the generated schema which
is fixed here.
The query parameter parsing is now done with
the
qslibrary instead of the previous manualparsing and some test coverage is added to handle
both valid and invalid query parameter calls.