Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random 8 character hex string confirmation code to applications #1854

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

pbn4
Copy link
Contributor

@pbn4 pbn4 commented Sep 21, 2021

Pull Request Template

Issue

Addresses # (#1074)

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Add random 8 character hex string confirmation code to applications. Existing applications confirmationCode addition is handled by a migration.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Please describe the tests that you ran to verify your changes. Provide instructions so we can review. Please also list any relevant details for your test configuration

  • Desktop View
  • Mobile View
  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes

@netlify
Copy link

netlify bot commented Sep 21, 2021

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: dc44efb

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/6149c27f9d92fd000784fea0

😎 Browse the preview: https://deploy-preview-1854--dev-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 21, 2021

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: dc44efb

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/6149c27fb596e50008a4a6f4

😎 Browse the preview: https://deploy-preview-1854--dev-storybook-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 21, 2021

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: dc44efb

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/6149c27feafcce0008dbe622

😎 Browse the preview: https://deploy-preview-1854--dev-partners-bloom.netlify.app

Copy link
Collaborator

@seanmalbert seanmalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbn4 ,
I think this look good, although if a use case comes up for using confirmation codes within the system I think we should enforce that it's accompanied by the listing or some other information like the applicants name, so we can know for sure that it's the right application.

@pbn4 pbn4 merged commit 18a278a into dev Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants