From f9fbe27c3750e29ac40f6c10498aa6d661661f08 Mon Sep 17 00:00:00 2001 From: Matt Wozniski Date: Fri, 11 Nov 2022 15:36:28 -0500 Subject: [PATCH] Stop warning that macOS support is experimental Previously this warning would be printed each time a `Tracker` was constructed, which caused a lot of noise when `pytest-memray` was being used, since it creates one `Tracker` per pytest test. Since we haven't heard any reports from users of any cases where things are actually broken on macOS, and since our documentation lists all of the known limitations in considerable detail, we've decided to stop considering macOS support to be experimental, and to drop the warning. Signed-off-by: Matt Wozniski --- docs/supported_environments.rst | 2 +- news/194.feature | 1 + src/memray/_memray.pyx | 8 -------- 3 files changed, 2 insertions(+), 9 deletions(-) create mode 100644 news/194.feature diff --git a/docs/supported_environments.rst b/docs/supported_environments.rst index 23a856de29..61d8a41c6c 100644 --- a/docs/supported_environments.rst +++ b/docs/supported_environments.rst @@ -18,7 +18,7 @@ Supported operating systems You will have the best Memray experience on Linux. -We have experimental support for macOS 11 or newer. We cannot support older +We also support macOS 11 or newer. We cannot support older macOS versions, as they don't provide a C++17 compatible runtime. Although all features work on macOS, the way that macOS applications and Python libraries are typically distributed often results in subpar native stacks on Mac. See diff --git a/news/194.feature b/news/194.feature new file mode 100644 index 0000000000..e7fc776660 --- /dev/null +++ b/news/194.feature @@ -0,0 +1 @@ +Memray is now fully supported on macOS, and the warnings that macOS support is experimental have been dropped. diff --git a/src/memray/_memray.pyx b/src/memray/_memray.pyx index 1d679a36a8..2c64f21715 100644 --- a/src/memray/_memray.pyx +++ b/src/memray/_memray.pyx @@ -367,14 +367,6 @@ cdef class Tracker: else: raise TypeError("destination must be a SocketDestination or FileDestination") - def __init__(self, object file_name=None, *, object destination=None, - bool native_traces=False, unsigned int memory_interval_ms = 10, - bool follow_fork=False, bool trace_python_allocators=False): - if sys.platform == "darwin": - pprint(":warning: [bold red] Memray support in MacOS is still experimental [/]:warning:", file=sys.stderr) - pprint("[yellow]Please report any issues at https://github.com/bloomberg/memray/issues[/]", file=sys.stderr) - pprint("", file=sys.stderr) - def __cinit__(self, object file_name=None, *, object destination=None, bool native_traces=False, unsigned int memory_interval_ms = 10, bool follow_fork=False, bool trace_python_allocators=False):