From 81b103681f39a9575aeedfcb5778663d84b2f9df Mon Sep 17 00:00:00 2001 From: nsyed22 Date: Fri, 5 May 2023 11:38:55 -0400 Subject: [PATCH] CR changes --- pybossa/view/account.py | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/pybossa/view/account.py b/pybossa/view/account.py index e994dbe3b..89230ca7c 100644 --- a/pybossa/view/account.py +++ b/pybossa/view/account.py @@ -1157,15 +1157,10 @@ def add_metadata(name): def bookmarks_dict_to_array(bookmarks_dict, order_by, desc): - order_by = "name" if order_by is None else order_by - desc = False if desc is None else desc - - bookmarks_array = [] - for name, meta in bookmarks_dict.items(): - b = {'name': name} - b.update(meta) - bookmarks_array.append(b) + order_by = order_by or "name" + desc = desc or False + bookmarks_array = [{'name': name, **meta} for name, meta in bookmarks_dict.items()] bookmarks_array.sort(key=lambda b: b[order_by], reverse=desc) return bookmarks_array @@ -1239,7 +1234,7 @@ def taskbrowse_bookmarks(user_name, short_name): order_by = request.args.get('order_by', None, type=str) desc_str = request.args.get('desc', None) - desc = True if desc_str == 'true' else False if desc_str == 'false' else None + desc = {'true': True, 'false': False}.get(desc_str) # get bookmarks for project from cache if request.method == 'GET':