diff --git a/pybossa/api/task.py b/pybossa/api/task.py index a22715f4f0..9d1645302b 100644 --- a/pybossa/api/task.py +++ b/pybossa/api/task.py @@ -63,8 +63,7 @@ def _forbidden_attributes(self, data): def _update_attribute(self, new, old): for key, value in old.info.items(): - if not new.info.get(key): - new.info[key] = value + new.info.setdefault(key, value) gold_task = bool(new.gold_answers) n_taskruns = len(new.task_runs) diff --git a/pybossa/api/task_run.py b/pybossa/api/task_run.py index da2ce95f4b..61e82b2b3d 100644 --- a/pybossa/api/task_run.py +++ b/pybossa/api/task_run.py @@ -116,8 +116,7 @@ def _update_object(self, taskrun): def _update_attribute(self, new, old): for key, value in old.info.items(): - if not new.info.get(key): - new.info[key] = value + new.info.setdefault(key, value) def _forbidden_attributes(self, data): for key in data.keys(): diff --git a/pybossa/auth/taskrun.py b/pybossa/auth/taskrun.py index 713b796fc3..0a2659b948 100644 --- a/pybossa/auth/taskrun.py +++ b/pybossa/auth/taskrun.py @@ -75,7 +75,6 @@ def _update(self, user, taskrun): project = self.project_repo.get(taskrun.project_id) allow_taskrun_edit = project.info.get("allow_taskrun_edit") or False return user.admin or (allow_taskrun_edit and taskrun.user_id == user.id) - return user.admin or taskrun.user_id == user.id def _delete(self, user, taskrun):