Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDISCROWD-4705: Reserve task category #639

Merged
merged 9 commits into from Dec 6, 2021
Merged

RDISCROWD-4705: Reserve task category #639

merged 9 commits into from Dec 6, 2021

Conversation

dchhabda
Copy link

@dchhabda dchhabda commented Nov 4, 2021

Issue number of the reported bug or feature request: #

Describe your changes
A clear and concise description of the changes you have made.

Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.

Additional context
Add any other context about your contribution here.

@coveralls
Copy link

coveralls commented Nov 5, 2021

Pull Request Test Coverage Report for Build 5490

  • 156 of 163 (95.71%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 94.453%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pybossa/sched.py 116 123 94.31%
Totals Coverage Status
Change from base Build 5454: 0.01%
Covered Lines: 15326
Relevant Lines: 16226

💛 - Coveralls

pybossa/sched.py Outdated Show resolved Hide resolved
pybossa/sched.py Outdated Show resolved Hide resolved
pybossa/sched.py Show resolved Hide resolved
pybossa/sched.py Show resolved Hide resolved
pybossa/sched.py Show resolved Hide resolved
pybossa/sched.py Outdated Show resolved Hide resolved
pybossa/redis_lock.py Show resolved Hide resolved
ywrsusan
ywrsusan previously approved these changes Dec 2, 2021
Copy link

@ywrsusan ywrsusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good provided coverage passes. thank you

Copy link

@ywrsusan ywrsusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks!

@dchhabda dchhabda merged commit 2240a3a into master Dec 6, 2021
@XiChenn XiChenn deleted the reserve-lock branch January 5, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants