Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project attributes comparator #72

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

kwridan
Copy link
Contributor

@kwridan kwridan commented Dec 24, 2020

Issue number of the reported bug or feature request: #62

Describe your changes

  • Added a new attributes comparator to compare project attributes (such as organization name & last upgrade check version)

Testing performed

  • Run swift run xcdiff --tag attributes --verbose withing Fixtures
  • Verify the results include project attributes (like organization name)

e.g.

❌ ATTRIBUTES > Root project

⚠️  Value mismatch (3):

  • LastSwiftUpdateCheck
    ◦ 1110
    ◦ 1030

  • LastUpgradeCheck
    ◦ 1020
    ◦ 1030

  • ORGANIZATIONNAME
    ◦ Bloomberg LP
    ◦ Another Organization

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #72 (006590d) into main (ae2d79d) will increase coverage by 0.02%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   96.18%   96.21%   +0.02%     
==========================================
  Files          44       45       +1     
  Lines        1679     1718      +39     
==========================================
+ Hits         1615     1653      +38     
- Misses         64       65       +1     
Impacted Files Coverage Δ
Sources/XCDiffCore/Library/TargetsHelper.swift 92.85% <80.00%> (-0.70%) ⬇️
...s/XCDiffCore/Comparator/AttributesComparator.swift 100.00% <100.00%> (ø)
Sources/XCDiffCore/ComparatorType.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2d79d...006590d. Read the comment docs.

@kwridan kwridan force-pushed the feature/attributes-comparator branch from f195b21 to eaa6820 Compare December 24, 2020 09:17
marciniwanicki
marciniwanicki previously approved these changes Dec 28, 2020
Copy link
Contributor

@marciniwanicki marciniwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🤠

Tests/XCDiffCommandTests/CommandsRunnerTests.swift Outdated Show resolved Hide resolved
Part of: bloomberg#62

- Added a new attributes comparator to compare project attributes

Test Plan:

- Run `swift run xcdiff --tag attributes --verbose` withing `Fixtures`
- Verify the results include project attributes (like organization name)

Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
@kwridan kwridan merged commit c8c28f4 into bloomberg:main Jan 6, 2021
@kwridan kwridan deleted the feature/attributes-comparator branch January 6, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants