From 0056c00fa5e25484f4e5f45594a0e2b941794e89 Mon Sep 17 00:00:00 2001 From: blooper05 Date: Wed, 8 Jun 2022 15:22:42 +0900 Subject: [PATCH 1/4] =?UTF-8?q?=F0=9F=92=A1=20docs:=20Change=20reference?= =?UTF-8?q?=20URL=20descriptions=20to=20DocBlock-like=20tag=20style?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .markdownlint.yml | 2 +- .yamllint.yml | 1 + testdata/app/models/user.rb | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.markdownlint.yml b/.markdownlint.yml index e5dd1de..a5f4ec8 100644 --- a/.markdownlint.yml +++ b/.markdownlint.yml @@ -1,4 +1,4 @@ -# refs. https://github.com/DavidAnson/markdownlint/blob/HEAD/schema/.markdownlint.yaml +# @see https://github.com/DavidAnson/markdownlint/blob/HEAD/schema/.markdownlint.yaml --- default: true diff --git a/.yamllint.yml b/.yamllint.yml index 14ec9cc..cf7141a 100644 --- a/.yamllint.yml +++ b/.yamllint.yml @@ -1,3 +1,4 @@ +# @see https://github.com/adrienverge/yamllint/blob/HEAD/yamllint/conf/default.yaml --- extends: default diff --git a/testdata/app/models/user.rb b/testdata/app/models/user.rb index c9c1049..8497b0e 100644 --- a/testdata/app/models/user.rb +++ b/testdata/app/models/user.rb @@ -1,5 +1,5 @@ -# refs. https://github.com/flyerhzm/rails_best_practices/blob/HEAD/spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb#L12-L14 -# refs. https://github.com/flyerhzm/rails_best_practices/blob/HEAD/spec/rails_best_practices/reviews/protect_mass_assignment_review_spec.rb#L17-L18 +# @see https://github.com/flyerhzm/rails_best_practices/blob/HEAD/spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb#L12-L14 +# @see https://github.com/flyerhzm/rails_best_practices/blob/HEAD/spec/rails_best_practices/reviews/protect_mass_assignment_review_spec.rb#L17-L18 class User < ActiveRecord::Base default_scope -> { order('created_at desc') } end From 65cd7b865c6949650a2d1f2c959ab3d10f69a738 Mon Sep 17 00:00:00 2001 From: blooper05 Date: Wed, 8 Jun 2022 15:22:52 +0900 Subject: [PATCH 2/4] =?UTF-8?q?=F0=9F=93=9D=20docs(readme):=20Update=20`Us?= =?UTF-8?q?age`=20section?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6801cbb..e994d8a 100644 --- a/README.md +++ b/README.md @@ -68,7 +68,7 @@ jobs: name: runner / rails_best_practices runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: blooper05/action-rails_best_practices@v1 with: github_token: ${{ secrets.github_token }} From dd22ed7ca1741f6f97d71e89ed06661fea1e942b Mon Sep 17 00:00:00 2001 From: blooper05 Date: Fri, 17 Jun 2022 02:40:05 +0900 Subject: [PATCH 3/4] =?UTF-8?q?=F0=9F=93=9D=20docs(readme):=20Use=20`Shiel?= =?UTF-8?q?ds.io`=20for=20badges=20for=20visual=20consistency?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index e994d8a..07040b5 100644 --- a/README.md +++ b/README.md @@ -1,11 +1,11 @@ # action-rails_best_practices -[![test](https://github.com/blooper05/action-rails_best_practices/workflows/test/badge.svg)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow%3Atest) -[![reviewdog](https://github.com/blooper05/action-rails_best_practices/workflows/reviewdog/badge.svg)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow%3Areviewdog) -[![depup](https://github.com/blooper05/action-rails_best_practices/workflows/depup/badge.svg)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow%3Adepup) -[![release](https://github.com/blooper05/action-rails_best_practices/workflows/release/badge.svg)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow%3Arelease) -[![GitHub release (latest SemVer)](https://img.shields.io/github/v/release/blooper05/action-rails_best_practices?logo=github&sort=semver)](https://github.com/blooper05/action-rails_best_practices/releases) -[![action-bumpr supported](https://img.shields.io/badge/bumpr-supported-ff69b4?logo=github&link=https://github.com/haya14busa/action-bumpr)](https://github.com/haya14busa/action-bumpr) +[![test](https://img.shields.io/github/workflow/status/blooper05/action-rails_best_practices/test?label=test&logo=github&style=flat-square)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow:test) +[![reviewdog](https://img.shields.io/github/workflow/status/blooper05/action-rails_best_practices/reviewdog?label=reviewdog&logo=github&style=flat-square)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow:reviewdog) +[![depup](https://img.shields.io/github/workflow/status/blooper05/action-rails_best_practices/depup?label=depup&logo=github&style=flat-square)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow:depup) +[![release](https://img.shields.io/github/workflow/status/blooper05/action-rails_best_practices/release?label=release&logo=github&style=flat-square)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow:release) +[![GitHub release (latest SemVer)](https://img.shields.io/github/v/release/blooper05/action-rails_best_practices?logo=github&sort=semver&style=flat-square)](https://github.com/blooper05/action-rails_best_practices/releases) +[![action-bumpr supported](https://img.shields.io/badge/bumpr-supported-ff69b4?logo=github&style=flat-square)](https://github.com/haya14busa/action-bumpr) ![github-pr-review demo](https://user-images.githubusercontent.com/5299525/171834705-b2517107-e616-4289-8ed9-4e160164701c.png) ![github-pr-check demo](https://user-images.githubusercontent.com/5299525/171834709-130da062-3518-4b28-9a1c-24b58fe686b4.png) From 34c9c38e4d5d8e39defc4f7d7f7641c3aea7f9f7 Mon Sep 17 00:00:00 2001 From: blooper05 Date: Fri, 17 Jun 2022 02:48:10 +0900 Subject: [PATCH 4/4] =?UTF-8?q?=F0=9F=93=84=20chore:=20Update=20LICENSE=20?= =?UTF-8?q?file?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- LICENSE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LICENSE b/LICENSE index 4abeaba..4d86c93 100644 --- a/LICENSE +++ b/LICENSE @@ -1,6 +1,6 @@ MIT License -Copyright (c) 2021 reviewdog developers +Copyright (c) 2022 blooper05 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal