Fix for issue #75 and missing host exception #77

Merged
merged 2 commits into from Oct 1, 2012

Projects

None yet

2 participants

@vongruenigen

This commit fixes the issue I described in #75. The problem was that it tried to get the application from the Rails constant defined in your module rather than the top level Rails constant.

@vongruenigen vongruenigen reopened this Oct 1, 2012
@vongruenigen

Sorry for accidently closing the PR. Hmm @blowmage, don't know why the tests are failing and currently I can't spend any time on investigate why. Do you have time to take a look at it?

@vongruenigen vongruenigen include #url_options method
include #url_options method from https://github.com/rails/rails/blob/v3.2.8/actionpack/lib/action_dispatch/testing/integration.rb#L494
because otherwise you have to specify a host foreach url you want to generate dynamically in an integration test
48b862b
@vongruenigen

I just fixed another problem I was facing. When you want to generate a url through a url_helper (e.g. home_url) the following exception was thrown:

Missing host to link to! Please provide the :host parameter, set default_url_options[:host], 
or set :only_path to true

My last commit fixes this issue.

@blowmage blowmage merged commit fde9a17 into blowmage:master Oct 1, 2012

1 check failed

Details default The Travis build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment