Vc/multi shares #59
Merged
Vc/multi shares #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadiminc
requested review from
alexstolr,
meshin-dev,
andrew-blox and
axelrod-blox
IlyaVi
reviewed
Dec 5, 2023
IlyaVi
reviewed
Dec 5, 2023
IlyaVi
reviewed
Dec 5, 2023
IlyaVi
approved these changes
Dec 5, 2023
alexstolr
approved these changes
Dec 5, 2023
| @@ -56,7 +57,18 @@ async function main() { | |||
| privateKey | |||
| }); | |||
|
|
|||
| const keyShares = new KeyShares(); | |||
There was a problem hiding this comment.
You can add an argument of optional list of key share items to the constructor instead of adding after constructed.
There was a problem hiding this comment.
For higher flexibility of SDK it can be implemented.
@vadiminc please add this possibility
axelrod-blox
approved these changes
Dec 6, 2023
IlyaVi
approved these changes
Dec 7, 2023
meshin-dev
approved these changes
Dec 10, 2023
README.md
Outdated
|
|
||
| - keystore-path (kp) = The validator keystore file/folder path, if a folder is provided all keystore files within the provided folder will be split according to the provided arguments | ||
| - keystore (ks) = The validator keystore file path. Only one keystore file can be specified using this argument | ||
| - keystore-path (kp) = The path to the folder containing validator keystore files. If a folder is provided, all keystore files within the provided folder will be split according to the provided arguments. This argument should not be used together with the `keystore`` argument |
| @@ -56,7 +57,18 @@ async function main() { | |||
| privateKey | |||
| }); | |||
|
|
|||
| const keyShares = new KeyShares(); | |||
There was a problem hiding this comment.
For higher flexibility of SDK it can be implemented.
@vadiminc please add this possibility
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "ssv-keys", | |||
| "version": "1.0.5-dev", | |||
| "version": "1.0.6", | |||
There was a problem hiding this comment.
Use 1.1.0 version, it's breaking changes
There was a problem hiding this comment.
it's not possible for now, as it won't support old files format anymore (single shares)
src/lib/KeyShares/KeyShares.ts
Outdated
| // Using a helper function to process each item | ||
| const processItem = async (item: any) => { | ||
| const keySharesItem = new KeySharesItem(); | ||
| await keySharesItem.fromJson(item); |
There was a problem hiding this comment.
From json should be static class method and return class instance.
src/lib/KeyShares/KeyShares.ts
Outdated
| // Process each item in the array | ||
| for (const item of body.shares) { | ||
| const processedItem = await processItem(item); | ||
| this.shares.push(processedItem); |
There was a problem hiding this comment.
this.shares.push(KeySharesItem.fromJson(item));
vadiminc
added a commit
that referenced
this pull request
Dec 12, 2023
* improve sanitaze function * update build files * fix lint * fix lint * update help messages * upda operator public key validation and unify the way how to do that * fix readme * forgotten commit * tag 1.0.5-dev * Vc/multi shares (#59) * multi-shares logic and improvements in design * new logic * fix examples and tests * import/export improvement * update examples * updated tests * updated tests * add keyshares construct init new flow * update build * Vc/more extended tests and errors (#61) * add more covered tests and updated errors * version up to 1.0.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here>