Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

rvm doesn't like being called from a full path #30

Closed
wants to merge 1 commit into from

2 participants

@joehillen

I kept getting this error during every puppet run:

notice: /Stage[main]//Node[test]/Server::Www[stable]/Rvm_system_ruby[ruby-1.9.2-p180]/default_use: default_use changed 'false' to 'true'

It looks like rvm doesn't like to be called using it's full path, and so the default was never getting set.

This seems to fix the issue, but I'm willing to bet that this change will cause some other issue.

Do you think this an ok change?

@joehillen

Ok, that didn't fix it.

If I run sudo puppet agent --test I get:

 notice: /Stage[main]//Node[test]/Server::Www[stable]/Rvm_gemset[ruby-1.9.2-p180@stable]: Dependency Rvm_system_ruby[ruby-1.9.2-p180] has failures: true
 warning: /Stage[main]//Node[test]/Server::Www[stable]/Rvm_gemset[ruby-1.9.2-p180@stable]:Skipping because of failed dependencies
notice: /Stage[main]//Node[test]/Server::Www[stable]/Exec[compile-css]: Dependency Rvm_system_ruby[ruby-1.9.2-p180] has failures: true
 warning: /Stage[main]//Node[test]/Server::Www[stable]/Exec[compile-css]: Skipping because of failed dependencies
notice: /Stage[main]//Node[test]/Server::Www[stable]/Rvm_gem[ruby-1.9.2-p180@stable/bundler]: Dependency Rvm_system_ruby[ruby-1.9.2-p180] has failures: true
warning: /Stage[main]//Node[test]/Server::Www[stable]/Rvm_gem[ruby-1.9.2-p180@stable/bundler]: Skipping because of failed dependencies

But if I run it as root (i.e. sudo su -), it workes fine.

@joehillen

nevermind, turns out I should be using rvmsudo

@joehillen joehillen closed this
@blt04 blt04 referenced this pull request from a commit
@blt04 Fix broken default_use implementation in rvm_system_ruby
Using rvm --default use 1.9.2 no longer works in scripting mode.  We use
rvm alias create default instead.

Also fix a bug that prevents the default from being set when fist
installing a ruby version.

References #30.
11447dd
@blt04
Owner

Hi Joe. Thanks for the pull request. I believe the default_use bugs should be fixed in the latest commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 21, 2012
  1. Ruby default wasn't getting set because rvm doesn't like being called…

    Joe Hillenbrand authored
    … via a full path.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/puppet/provider/rvm_system_ruby/rvm_system_ruby.rb
View
2  lib/puppet/provider/rvm_system_ruby/rvm_system_ruby.rb
@@ -1,7 +1,7 @@
Puppet::Type.type(:rvm_system_ruby).provide(:rvm) do
desc "Ruby RVM support."
- commands :rvmcmd => "/usr/local/rvm/bin/rvm"
+ commands :rvmcmd => "rvm"
def create
rvmcmd "install", resource[:name]
Something went wrong with that request. Please try again.