From 01561c4dfd3ce08b058f4b42a45db1da4349381b Mon Sep 17 00:00:00 2001 From: David Christensen Date: Wed, 22 Mar 2023 13:29:33 -0400 Subject: [PATCH] acl: fix crash on PPC64 with GCC 11 [ upstream commit 3f62bba2e7aa15e5f1e418cdced0f4160de154b3 ] Original ACL implementation of Altivec optimized code included an explicit -O2 optimization level for a particular inlined function. When DPDK is built with the default -O3 optimization level on gcc 11.x or later, the resulting code may generate a segmentation fault as observed in acl_autotest. Since there is no explicit reason given for the local function optimization level in the original commit, and testing with gcc versions 8.x through 12.x results in working code at all -O optimization settings, the local optimization is removed. Bugzilla ID: 1197 Signed-off-by: David Christensen Tested-by: Thinh Tran --- lib/librte_acl/acl_run_altivec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_acl/acl_run_altivec.h b/lib/librte_acl/acl_run_altivec.h index 24a41eec17..317a036c84 100644 --- a/lib/librte_acl/acl_run_altivec.h +++ b/lib/librte_acl/acl_run_altivec.h @@ -102,7 +102,7 @@ acl_match_check_x4(int slot, const struct rte_acl_ctx *ctx, struct parms *parms, /* * Process 4 transitions (in 2 XMM registers) in parallel */ -static inline __attribute__((optimize("O2"))) xmm_t +static __rte_always_inline xmm_t transition4(xmm_t next_input, const uint64_t *trans, xmm_t *indices1, xmm_t *indices2) {