From 793c8206207f54ebaf20c96945edf248c6c503c6 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Tue, 30 Nov 2021 16:59:13 +0000 Subject: [PATCH] net/qede: fix redundant condition in debug code [ upstream commit 6caee3fb5f7b45ca7a676d77f678cafc4984defa ] Expression "a && 1" is equivalent to just "a", so fix the accidental inclusion of a literal in code. Fixes: ec55c118792b ("net/qede: add infrastructure for debug data collection") Signed-off-by: Anatoly Burakov Acked-by: Devendra Singh Rawat Reviewed-by: Igor Russkikh Acked-by: Rasesh Mody --- drivers/net/qede/qede_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_debug.c b/drivers/net/qede/qede_debug.c index af86bcc692..9383a6d677 100644 --- a/drivers/net/qede/qede_debug.c +++ b/drivers/net/qede/qede_debug.c @@ -3522,7 +3522,7 @@ static enum dbg_status qed_grc_dump(struct ecore_hwfn *p_hwfn, /* Dump MCP HW Dump */ if (qed_grc_is_included(p_hwfn, DBG_GRC_PARAM_DUMP_MCP_HW_DUMP) && - !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP) && 1) + !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP)) offset += qed_grc_dump_mcp_hw_dump(p_hwfn, p_ptt, dump_buf + offset, dump);