From 964a78f4be1e1e5be526541d8f1e00494946f641 Mon Sep 17 00:00:00 2001 From: Ivan Malov Date: Wed, 9 Feb 2022 02:26:47 +0300 Subject: [PATCH] net/sfc: do not push fast free offload to default TxQ config [ upstream commit f67615ea626e23e61b71d27f894fe9a4ef716df3 ] Doing so is wrong since fast free is an adapter-wide offload. Technically, the offending commit (see "Fixes" tag) does not induce failures, however, such started to occur after commit a4996bd89c42 ("ethdev: new Rx/Tx offloads API") had shown up, because of the strict offload validation in the generic code. Fixes: c78d280e88ef ("net/sfc: convert to new Tx offload API") Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_ethdev.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 7c2bf78da0..1b02759f93 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -86,7 +86,6 @@ sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev); struct sfc_rss *rss = &sas->rss; struct sfc_mae *mae = &sa->mae; - uint64_t txq_offloads_def = 0; sfc_log_init(sa, "entry"); @@ -138,11 +137,6 @@ sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->tx_offload_capa = sfc_tx_get_dev_offload_caps(sa) | dev_info->tx_queue_offload_capa; - if (dev_info->tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) - txq_offloads_def |= DEV_TX_OFFLOAD_MBUF_FAST_FREE; - - dev_info->default_txconf.offloads |= txq_offloads_def; - if (rss->context_type != EFX_RX_SCALE_UNAVAILABLE) { uint64_t rte_hf = 0; unsigned int i;