From 9c9fad3dfa042ae4b7a045cb1731f8701f8210e6 Mon Sep 17 00:00:00 2001 From: Megha Ajmera Date: Wed, 23 Feb 2022 17:36:30 +0000 Subject: [PATCH] examples/qos_sched: fix core mask overflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Masking of core mask was incorrect. Instead of using 1U for shifting, it should be using 1LU as the result is assigned to uint64. CID 375859: Potentially overflowing expression "1U << app_main_core" with type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "uint64_t" (64 bits, unsigned). Coverity issue: 375859 Fixes: de3cfa2c9823 ("sched: initial import") Cc: stable@dpdk.org Signed-off-by: Megha Ajmera Acked-by: Morten Brørup --- examples/qos_sched/args.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c index 10ca7bea61..b2959499ae 100644 --- a/examples/qos_sched/args.c +++ b/examples/qos_sched/args.c @@ -427,13 +427,13 @@ app_parse_args(int argc, char **argv) /* check main core index validity */ for (i = 0; i <= app_main_core; i++) { - if (app_used_core_mask & (1u << app_main_core)) { + if (app_used_core_mask & RTE_BIT64(app_main_core)) { RTE_LOG(ERR, APP, "Main core index is not configured properly\n"); app_usage(prgname); return -1; } } - app_used_core_mask |= 1u << app_main_core; + app_used_core_mask |= RTE_BIT64(app_main_core); if ((app_used_core_mask != app_eal_core_mask()) || (app_main_core != rte_get_main_lcore())) {