Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Fix class name when generating metrics for Object Detection #494

Merged
merged 11 commits into from Oct 9, 2019
Merged

Fix class name when generating metrics for Object Detection #494

merged 11 commits into from Oct 9, 2019

Conversation

Joeper214
Copy link
Contributor

@Joeper214 Joeper214 commented Oct 4, 2019 •
edited

Motivation and Context

The class name cannot be generated from tensorboard metrics this PR fixes this Issue.

Description

How has this been tested?

  • Try to train an yolov2 or yolov1 task using MScoco dataset.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Joeper214 Joeper214 self-assigned this Oct 4, 2019
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Oct 4, 2019
@Joeper214 Joeper214 marked this pull request as ready for review October 4, 2019 06:31
@Joeper214 Joeper214 changed the title Fix class name when generating metrics for yolov2 Fix class name when generating metrics for Object Detection Oct 4, 2019
@Joeper214 Joeper214 requested a review from iizukak October 8, 2019 01:49
@Joeper214 Joeper214 removed the request for review from nlpng October 8, 2019 02:42
iizukak
iizukak approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

@tkng
Copy link
Contributor

tkng commented Oct 9, 2019

Readability Approval

@Joeper214
Copy link
Contributor Author

@tkng @iizukak Is this okay to merge?

@tkng
Copy link
Contributor

tkng commented Oct 9, 2019

Yes, I just waited the completion of unit tests.

@tkng tkng merged commit 297ce58 into blue-oil:master Oct 9, 2019
@Joeper214 Joeper214 deleted the fix_class_name_on_metrics branch October 9, 2019 07:13
@iizukak iizukak added this to the v0.13.0 milestone Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@tkng tkng Awaiting requested review from tkng

Assignees

@Joeper214 Joeper214

Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

MscocoObjectDetection does not work.
3 participants
@Joeper214 @tkng @iizukak