Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tsfresh compatible with numpy 1.24 #1018

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Conversation

nils-braun
Copy link
Collaborator

Related to #1017.

Remove all np.object which are deprecated in the newest numpy.
Please note that since numba (needed by stumpy) is not compatible with the newest numpy, this makes tsfresh itself not compatible with it yet. But once numba releases, this will automatically happen.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (e91e2a3) 93.42% compared to head (3b1317f) 93.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1018   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files          20       20           
  Lines        1886     1886           
  Branches      371      371           
=======================================
  Hits         1762     1762           
  Misses         85       85           
  Partials       39       39           
Impacted Files Coverage Δ
tsfresh/utilities/dataframe_functions.py 95.83% <0.00%> (ø)
tsfresh/feature_selection/relevance.py 85.84% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nils-braun nils-braun merged commit 5430dc1 into main Jun 8, 2023
@nils-braun nils-braun deleted the feature/numpy-1-24 branch June 8, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants