New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up tests #308

Merged
merged 10 commits into from Aug 30, 2017

Conversation

Projects
None yet
3 participants
@nils-braun
Collaborator

nils-braun commented Aug 29, 2017

Using some "fancy" if conditions with travis, smaller statistics for some tests and general refactoring, I could speed up our unittests frm 27 minutes to 6 minutes on travis.
We are only running the "small" unittests on branches and PR now and the full integration tests on master.
Also deployment is only enabled on tags (as before).

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 29, 2017

Coverage Status

Coverage decreased (-6.6%) to 92.134% when pulling a536c34 on speed-up-tests into ae682ba on master.

coveralls commented Aug 29, 2017

Coverage Status

Coverage decreased (-6.6%) to 92.134% when pulling a536c34 on speed-up-tests into ae682ba on master.

@nils-braun

This comment has been minimized.

Show comment
Hide comment
@nils-braun

nils-braun Aug 29, 2017

Collaborator

Well, we do have a coverage drop here of course, because the coverage is now only calculated on the unit tests - not on the integration tests.

Collaborator

nils-braun commented Aug 29, 2017

Well, we do have a coverage drop here of course, because the coverage is now only calculated on the unit tests - not on the integration tests.

@nils-braun nils-braun requested a review from MaxBenChrist Aug 29, 2017

@MaxBenChrist

This comment has been minimized.

Show comment
Hide comment
@MaxBenChrist

MaxBenChrist Aug 29, 2017

Collaborator

Well, we do have a coverage drop here of course, because the coverage is now only calculated on the unit tests - not on the integration tests.

I do not think that this pr is the way to go. We will end up with masters with dropped coverages or where the integration tests are failing.

Collaborator

MaxBenChrist commented Aug 29, 2017

Well, we do have a coverage drop here of course, because the coverage is now only calculated on the unit tests - not on the integration tests.

I do not think that this pr is the way to go. We will end up with masters with dropped coverages or where the integration tests are failing.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 29, 2017

Coverage Status

Coverage decreased (-0.9%) to 97.801% when pulling 954e6c1 on speed-up-tests into ae682ba on master.

coveralls commented Aug 29, 2017

Coverage Status

Coverage decreased (-0.9%) to 97.801% when pulling 954e6c1 on speed-up-tests into ae682ba on master.

@nils-braun

This comment has been minimized.

Show comment
Hide comment
@nils-braun

nils-braun Aug 29, 2017

Collaborator

ok, I have fixed the coverage problem. The only file, that really changed between unit and integration tests is the driftbuf_simulation - which is just an example and is not needed to have full coverage in my opinion.

Collaborator

nils-braun commented Aug 29, 2017

ok, I have fixed the coverage problem. The only file, that really changed between unit and integration tests is the driftbuf_simulation - which is just an example and is not needed to have full coverage in my opinion.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 29, 2017

Coverage Status

Coverage decreased (-0.9%) to 97.801% when pulling 4aafbc4 on speed-up-tests into ae682ba on master.

coveralls commented Aug 29, 2017

Coverage Status

Coverage decreased (-0.9%) to 97.801% when pulling 4aafbc4 on speed-up-tests into ae682ba on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 29, 2017

Coverage Status

Coverage decreased (-0.9%) to 97.801% when pulling fe4e55b on speed-up-tests into ae682ba on master.

coveralls commented Aug 29, 2017

Coverage Status

Coverage decreased (-0.9%) to 97.801% when pulling fe4e55b on speed-up-tests into ae682ba on master.

@nils-braun

This comment has been minimized.

Show comment
Hide comment
@nils-braun

nils-braun Aug 29, 2017

Collaborator

Perfect - unit tests are already finished - integration is still running :-)

Collaborator

nils-braun commented Aug 29, 2017

Perfect - unit tests are already finished - integration is still running :-)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 29, 2017

Coverage Status

Coverage decreased (-0.06%) to 98.681% when pulling aa60af3 on speed-up-tests into ae682ba on master.

coveralls commented Aug 29, 2017

Coverage Status

Coverage decreased (-0.06%) to 98.681% when pulling aa60af3 on speed-up-tests into ae682ba on master.

@MaxBenChrist MaxBenChrist merged commit 840a3d9 into master Aug 30, 2017

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.06%) to 98.681%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment