From f4096de43554662a48259de8b63194dc4071ae51 Mon Sep 17 00:00:00 2001 From: Kyle Altendorf Date: Sat, 3 Oct 2020 20:28:56 -0400 Subject: [PATCH 1/2] `pyqtBoundSignal.disconnect()`'s `slot` parameter is optional --- CHANGELOG.md | 1 + PyQt5-stubs/QtCore.pyi | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index adb4c64b..a94d461c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). * [#51](https://github.com/stlehmann/PyQt5-stubs/pull/51) adds `pyqtBoundSignal.signal` hinted as `str` ### Changed +* [#103](https://github.com/stlehmann/PyQt5-stubs/pull/103) `pyqtBoundSignal.disconnect()`'s `slot` parameter is optional * [#92](https://github.com/stlehmann/PyQt5-stubs/pull/92) remove self from `qDefaultSurfaceFormat()` and `qIdForNode()` * [#83](https://github.com/stlehmann/PyQt5-stubs/pull/83) fixes `sip.array` to be generic * [#79](https://github.com/stlehmann/PyQt5-stubs/pull/79) fixes extra class layer in several modules diff --git a/PyQt5-stubs/QtCore.pyi b/PyQt5-stubs/QtCore.pyi index 3df7c2fa..9ace43f1 100644 --- a/PyQt5-stubs/QtCore.pyi +++ b/PyQt5-stubs/QtCore.pyi @@ -35,7 +35,7 @@ class pyqtBoundSignal: def emit(self, *args: typing.Any) -> None: ... def connect(self, slot: "PYQT_SLOT") -> "QMetaObject.Connection": ... - def disconnect(self, slot: typing.Union["PYQT_SLOT", "QMetaObject.Connection"]=None) -> None: ... + def disconnect(self, slot: typing.Optional[typing.Union["PYQT_SLOT", "QMetaObject.Connection"]]=None) -> None: ... class pyqtSignal: From 7d4e18023cafcb5bef2500b9bf7af9e6c829eb53 Mon Sep 17 00:00:00 2001 From: Kyle Altendorf Date: Sun, 4 Oct 2020 09:24:34 -0400 Subject: [PATCH 2/2] Update PyQt5-stubs/QtCore.pyi --- PyQt5-stubs/QtCore.pyi | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PyQt5-stubs/QtCore.pyi b/PyQt5-stubs/QtCore.pyi index 9ace43f1..e17079b5 100644 --- a/PyQt5-stubs/QtCore.pyi +++ b/PyQt5-stubs/QtCore.pyi @@ -35,7 +35,10 @@ class pyqtBoundSignal: def emit(self, *args: typing.Any) -> None: ... def connect(self, slot: "PYQT_SLOT") -> "QMetaObject.Connection": ... - def disconnect(self, slot: typing.Optional[typing.Union["PYQT_SLOT", "QMetaObject.Connection"]]=None) -> None: ... + @typing.overload + def disconnect(self) -> None: ... + @typing.overload + def disconnect(self, slot: typing.Union["PYQT_SLOT", "QMetaObject.Connection"]) -> None: ... class pyqtSignal: