Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: changes from fredvd and datakurre improvements. #37

Merged
merged 0 commits into from Sep 6, 2019

Conversation

rnixx
Copy link
Member

@rnixx rnixx commented Dec 15, 2017

Keep track of changes and improvements made by @fredvd and @datakurre.

@rnixx
Copy link
Member Author

rnixx commented Apr 16, 2019

This PR should be rebased to master and only implement search_attrlist improvement. Then we can merge

@fredvd
Copy link
Contributor

fredvd commented Apr 16, 2019

@rnixx What's the issue with the things that were fixed, not to merge them?

@rnixx
Copy link
Member Author

rnixx commented Apr 16, 2019

@fredvd What fixes are left there except the query normalization?

UPDATE Let me say it from the other direction. All the encode/docode changes can be dropped due to behavioral changes in python-ldap. Query normalization in node and ugm shoud stay.

@mauritsvanrees
Copy link
Contributor

As known, this PR is outdated, and cannot be merged in this condition.
I have created a branch https://github.com/zestsoftware/node.ext.ldap/tree/fixes-from-datakurre-and-zest with these changes, so we know the state in which this PR was left. It is the same as the datakurre/master branch.

I will sync our master branch with the original bluedynamics one, and create a fresh branch for Fred's fix 43cc656.

You can close this PR, I will create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants