Common attributes dictionary method #11

Merged
merged 5 commits into from Jun 21, 2012

Conversation

Projects
None yet
3 participants
@thet
Member

thet commented Jun 16, 2012

input attributes are used all over the common.py blueprint definitions. the superset of all of those attributes can be applied to all input tags. so, i factored out input_attributes_common and input_attributes_full to be used in all blueprints. specific keys like name_, type and value can be overloaded by the blueprints. this makes it easier to extend the available attributes and to reuse common attributes in custom blueprints.

tests pass, except one, which also doesn't pass on current master.

@rnixx

This comment has been minimized.

Show comment Hide comment
@rnixx

rnixx Jun 20, 2012

Member

this one looks good to me. lets wait for jens opinion and merge if no objections

Member

rnixx commented Jun 20, 2012

this one looks good to me. lets wait for jens opinion and merge if no objections

jensens added a commit that referenced this pull request Jun 21, 2012

Merge pull request #11 from bluedynamics/common-attributes
Common attributes dictionary method

@jensens jensens merged commit 2e7cf3b into master Jun 21, 2012

@jensens jensens deleted the common-attributes branch Nov 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment