Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update edit-step-as-json to handle the antiforgery token introduced in 3.12.0 #96

Conversation

@matt-richardson
Copy link
Contributor

commented Aug 19, 2017

Fixes #94

Tested against 3.16.3 and against 3.11.0.

Update edit-step-as-json to handle the antiforgery token introduced i…
…n 3.12.0

Tested against 3.16.3 and against 3.11.0

@matt-richardson matt-richardson requested a review from davidroberts63 Aug 19, 2017

@davidroberts63

This comment has been minimized.

Copy link
Collaborator

commented Sep 13, 2017

Thanks @matt-richardson. I appreciate your patience in my greatly delayed response on this. Looking at it today.

@@ -58,9 +61,11 @@ pygmy3_0.editStepAsJsonHandler = (function() {
getJsonResponse(url, handler);
}

function handleEditedStepAsJsonRequest(request, sendResponse, octopusRoot, getJsonResponse, handleEditedStepGetResponse, putJsonRequest) {
function handleEditedStepAsJsonRequest(request, sendResponse, octopusRoot, getJsonResponse, handleEditedStepGetResponse, putJsonRequest, antiForgeryToken) {

This comment has been minimized.

Copy link
@davidroberts63

davidroberts63 Sep 13, 2017

Collaborator

Why the antiForgeryToken parameter here? Looks like you pull it from the request object on line 67.

This comment has been minimized.

Copy link
@matt-richardson

matt-richardson Sep 22, 2017

Author Contributor

Missed your reply - oops.
That does look odd - I'll take a look...

This comment has been minimized.

Copy link
@matt-richardson

matt-richardson Sep 23, 2017

Author Contributor

Okay, fix pushed. Think it must have been an early attempt that got left behind.

@davidroberts63

This comment has been minimized.

Copy link
Collaborator

commented Oct 5, 2017

Okay. I'll merge and publish this weekend.

@davidroberts63 davidroberts63 merged commit c6b707d into bluefin-octopusdeploy:master Oct 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.