Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old client to future #87

Merged
merged 5 commits into from Jan 16, 2017
Merged

Old client to future #87

merged 5 commits into from Jan 16, 2017

Conversation

bluejekyll
Copy link
Member

Rearchitected the original Client into SyncClient and SecureSyncClient. This is a breaking change.

@zsck if you have a minute, would you mind looking at this and let me know if these changes are too aggressive? It should be a relatively straightforward upgrade. You're currently the only person I know is relying on this.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.6%) to 89.89% when pulling 39c8813 on old_client_to_future into 01c0153 on master.

@bluejekyll
Copy link
Member Author

coverage, 90% badge, woohoo!

@bluejekyll bluejekyll added this to the 0.10.0 milestone Jan 16, 2017
@bluejekyll bluejekyll merged commit 1851904 into master Jan 16, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+3.6%) to 89.89% when pulling aa0216a on old_client_to_future into aeb484a on master.

@bluejekyll bluejekyll deleted the old_client_to_future branch February 25, 2017 08:46
@mathstuf
Copy link
Contributor

Note that this means that users which are required to be Send + Sync must now create a resolver on each use rather than being able to create their Client just once. See #227.

@bluejekyll
Copy link
Member Author

All client handles are cloneable, not sync. Have you tried using clone to facilitate your needs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants