Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pb_type_t prevents usage of btstack with nanopb #249

Closed
piotrkundu opened this issue Sep 9, 2019 · 2 comments

Comments

@piotrkundu
Copy link

commented Sep 9, 2019

https://github.com/bluekitchen/btstack/blob/master/src/mesh/provisioning_device.c#L149

https://github.com/bluekitchen/btstack/blob/master/src/mesh/provisioning.h#L90

I'm adding nanopb to my project and got some name clashes. Perhaps renaming to bt_pb_type_t or something is enough. Unless there are other ways to avoid name clashes.

Running on develop branch at commit ec818a2

@mringwal

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Hi. We're already prefixing most common data types (e.g. btstack_linked_list, btstack_ring_buffer..). pb_type_t is only used inside mesh, we will rename it and let you know (probably mesh_pb_type_t)

@piotrkundu

This comment has been minimized.

Copy link
Author

commented Sep 9, 2019

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.