Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: expected unqualified-id ::mpfr_set(m_value, other.m_value, default_rnd); #151

Open
yurivict opened this issue Aug 31, 2021 · 7 comments

Comments

@yurivict
Copy link

The python binding fails to build:

In file included from /wrkdirs/usr/ports/math/py-piranha/work-py38/piranha-0.11/pyranha/core.cpp:64:
/wrkdirs/usr/ports/math/py-piranha/work-py38/piranha-0.11/pyranha/../src/real.hpp:751:11: error: expected unqualified-id
        ::mpfr_set(m_value, other.m_value, default_rnd);
          ^
/usr/local/include/mpfr.h:882:3: note: expanded from macro 'mpfr_set'
  __extension__ ({                              \
  ^
In file included from /wrkdirs/usr/ports/math/py-piranha/work-py38/piranha-0.11/pyranha/core.cpp:64:
/wrkdirs/usr/ports/math/py-piranha/work-py38/piranha-0.11/pyranha/../src/real.hpp:811:11: error: expected unqualified-id
        ::mpfr_set(m_value, other.m_value, default_rnd);
          ^
/usr/local/include/mpfr.h:882:3: note: expanded from macro 'mpfr_set'
  __extension__ ({                              \
  ^
In file included from /wrkdirs/usr/ports/math/py-piranha/work-py38/piranha-0.11/pyranha/core.cpp:64:
/wrkdirs/usr/ports/math/py-piranha/work-py38/piranha-0.11/pyranha/../src/real.hpp:856:15: error: expected unqualified-id
            ::mpfr_set(m_value, other.m_value, default_rnd);
              ^
/usr/local/include/mpfr.h:882:3: note: expanded from macro 'mpfr_set'
  __extension__ ({                              \
  ^
3 errors generated.

Version: 0.11
clang-11
FreeBSD 13

@yurivict
Copy link
Author

yurivict commented Oct 5, 2021

@yurivict
Copy link
Author

@bluescarni

Hi Francesco,

Could you please fix this?

Thank you,
Yuri

@7ofNine
Copy link
Contributor

7ofNine commented Oct 25, 2021

@yurivict
Hi Yuri,
I can't speak for Francesco but I worked with those libraries since its predecessor and I don't expect anybody changing anything in it. It is software that hasn't seen any changes for more than three years and it is rather outdated. v0.11 seems to have been a specific fix for gcc and I am even not sure which mp++ version is needed. I also doubt that the python binding was ever completely implemented and meanwhile everything should be Python 3 anyways. Depending on what you want do with it doesn't have all the features implemented that its predecessor possessed related to celestial mechanics. The lack of documentation points also at the fact that it is not a released version. Your choice here is probably to implement any changes you need by yourself, which doesn't look to be to difficult in this case.
The next step could also be obake as successor of piranha. But I think this probably still has some missing functionality and I don't think that there is a python binding currently existing.

Cheers
Hartmuth

@yurivict
Copy link
Author

@bluescarni
This is still an issue. Could you please take a look?

@bluescarni
Copy link
Owner

@yurivict sorry for the delayed reply. As @7ofNine says, piranha development is dormant since a while. There is a successor project called obake:

https://github.com/bluescarni/obake

but it does not have all the features in piranha and development is slow there because these days I am focusing more on software projects (such as heyoka) more directly related to my research work.

I'll try to take a look at these issues the next few days (which I suspect are similar to the ones you reported for mp++), but can't promise on an ETA.

@7ofNine
Copy link
Contributor

7ofNine commented Feb 10, 2022

@bluescarni, @yurivict
Hi Francesco, Yuri
I have a version of piranha that is updated to a modern version of mp++ in my repository. But there is no guarantee that it works with anything else than >VS2019 and C++20 and on my machine. There has been no compilations/tests done under anything else but a Windows environment . This also means the CMAKE files might be not correctly working for anything else but the above situation. But of course you may use it as a starter or as it is. There are also intermediate versions that could be better suited as a starter. You' ll find it here

@7ofNine
Copy link
Contributor

7ofNine commented Feb 10, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants