Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getActorLikes #1440

Merged
merged 18 commits into from
Aug 22, 2023
Merged

add getActorLikes #1440

merged 18 commits into from
Aug 22, 2023

Conversation

estrattonbailey
Copy link
Member

We use the term actor in the errors/params, and since a Like could originate from a bot or human, decided actor the better term.

Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup schema looks right 👍

@estrattonbailey estrattonbailey changed the title add getActorLikes lexicon add getActorLikes Aug 15, 2023
* origin: (21 commits)
  styleguide
  Increase CI test matrix size (#1490)
  tweak author-feed rejects test syntax
  update test
  format
  add repost of reply, update snaps
  simplify query
  fix typos
  include reposted replies in posts_no_replies filter
  fix bad test syntax
  fix actor takedown tests
  use getActor, failing atm
  only include media posts by post creator
  Fix condition for viewing soft-deleted followers (#1485)
  ✨ Expose takendown profile, their follows and followers to mods (#1456)
  Handle revalidation (#1474)
  Handle db pool errors on appview (#1483)
  Handle db client errors on appview (#1481)
  v0.6.4
  ✨ Allow creating moderation action with a duration (#1431)
  ...
* origin:
  Runtime flags in PDS, appview-proxy flags (#1491)
@estrattonbailey estrattonbailey marked this pull request as ready for review August 21, 2023 16:23
Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small things but overall looking good!

* origin:
  Tweak rate limits (#1502)
  Fix auth on bsky author feed (#1501)
  Bugfix: Application ratelimits relative import (#1500)
  Application ratelimits (#1382)
  format
  do not notify users of own-actions
  Fix runtime flags open handles (#1497)
  make sure to await rejected promise expectations
  Misc fixes (#1492)
Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet looks great 🙌

@estrattonbailey estrattonbailey merged commit 8d0c622 into main Aug 22, 2023
@estrattonbailey estrattonbailey deleted the eric/app-796-likes-tab branch August 22, 2023 16:36
@gildaswise
Copy link

Hey, what's the reason for 9b1f5f0 which disallows seeing other profile's likes? Shouldn't that be something each client decides? The statement was "Those likes can still be accessed by APIs, so other apps may show them."

@estrattonbailey
Copy link
Member Author

Good question, and totally understand the confusion. The distinction here is that Like records are public i.e. they are publicized via our BGS, but we chose not to provide access to that data from our App View.

Clients can opt to interact with our App View APIs, or choose make their own set of APIs if they want to make different decisions that we have. Some users have already done this but ingesting Like records from our BGS and providing them as custom feeds.

mloar pushed a commit to mloar/atproto that referenced this pull request Nov 15, 2023
LilahTovMoon added a commit to LilahTovMoon/atproto that referenced this pull request Jun 21, 2024
You can only view your own likes and this fixes the documentation to note that auth is required and that the actor must be the requesting account

bluesky-social#1440 (comment)
devinivy pushed a commit that referenced this pull request Aug 17, 2024
You can only view your own likes and this fixes the documentation to note that auth is required and that the actor must be the requesting account

#1440 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants