Properly validate auth during refresh#3847
Merged
Merged
Conversation
… used to create the OAuth tokens.
matthieusieben
marked this pull request as draft
May 10, 2025 09:16
…lient (private_key_jwt)
…her than the kid only
…d` is used in the client metadata document.
matthieusieben
commented
May 15, 2025
matthieusieben
marked this pull request as ready for review
May 15, 2025 12:39
matthieusieben
commented
May 15, 2025
matthieusieben
commented
May 19, 2025
matthieusieben
commented
May 19, 2025
matthieusieben
commented
May 19, 2025
matthieusieben
commented
May 19, 2025
devinivy
reviewed
May 20, 2025
devinivy
reviewed
May 20, 2025
Co-authored-by: devin ivy <devinivy@gmail.com>
devinivy
reviewed
Jun 12, 2025
devinivy
reviewed
Jun 12, 2025
devinivy
reviewed
Jun 12, 2025
devinivy
reviewed
Jun 12, 2025
devinivy
reviewed
Jun 12, 2025
devinivy
reviewed
Jun 12, 2025
devinivy
reviewed
Jun 12, 2025
devinivy
reviewed
Jun 12, 2025
devinivy
approved these changes
Jun 12, 2025
…T's `jti` nonce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the credentials used during a refresh correspond to those used to create the OAuth tokens.
Warning
This introduces a breaking change for clients that declared multiple keys in their JWKS over time, and that do not re-use the same kid when refreshing sessions.
This includes clients built on top of our
@atproto/oauth-clientpackage.Note that spec compliant clients should be unaffected.