Increase oauth session & refresh token lifetimes#3883
Merged
Conversation
bnewbold
approved these changes
Jun 2, 2025
bnewbold
left a comment
bnewbold
left a comment
Collaborator
There was a problem hiding this comment.
I'd be happy to do another round of review/discussion on these numbers, but i'm also fine shipping them with these values.
+1 on the renaming of the constants, much easier to understand now.
matthieusieben
force-pushed
the
msi/oauth-lifetimes
branch
from
ffa3a88 to
fa78078
Compare
|
what work is needed to be completed for this to get merged? |
Merged
matthieusieben
added a commit
that referenced
this pull request
Jun 23, 2025
matthieusieben
added a commit
that referenced
this pull request
Jun 23, 2025
* Improve OAuth Example app * Improve style * bsync: Accept NSID with fragment in operation ns (#3954) * Add `match: MuteWordMatch` to `muted-word` mod decision `cause` (#2934) * Return MuteWordMatch instead of simple boolean * Return full mute word with match * Add MuteWordMatch to decision cause, update a few tests * Backwards compat * Tighter types * Return all mute word matches * Clean up types * Rename * More cleanup of naming * Remove unneeded changes * Format * Add predicate value to matches * Better migration path * Changeset * Import sort * Tighten up addMuteWord API Co-authored-by: Matthieu Sieben <matthieusieben@users.noreply.github.com> * Mute words: handle `Andor` and `and/or` case (#3948) * Handle Andor case * Remove useless escape * Changeset --------- Co-authored-by: Matthieu Sieben <matthieusieben@users.noreply.github.com> * Version packages (#3947) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update README.md to add some missing details in examples (#3254) Update README.md Improve code examples (some OAuth implementation details are missing in these examples) * Increase oauth session & refresh token lifetimes (#3883) * Allow HTTPS `redirect_uris` from any origin (#3811) * bump MST key length from 256 to 1024 chars (#3956) * bump MST key length from 256 to 1024 chars * update MST key test * add a changeset * Version packages (#3959) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Rename `filter` -> `include` (#3966) * rename filter -> include * changeset * fix tests * Minor Fixes: Typo Correction and Comment Update (#3961) * Update blob-resolver.ts * Update index.ts * Appview: sync up protos for notification prefs (#3970) appview: sync up protos for notification prefs * Version packages (#3969) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix invalid use of `invalid_client` (#3967) * Replace slice() with subarray() in car file parsing (#3971) * Replace slice() with subarray() in car file parsing * changeset --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> * Re-export all types & utilities needed to instantiate an OAuth client (#3976) * Re-export all types & utilities needed to instantiate an OAuth client * Add `jwkPrivateSchema` to ensure a key is private * Return object instead of array as result of `findPrivateKey` * Allow override of default `handleResolver` and `runtimeImplementation` options for NodeOAuthClient * changeset * Allow `OAuthClient` to be instantiated with custom `didResolver` instance * Version packages (#3975) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Perform a bi-directional check when resolving identity from did (#3977) * Perform a bi-directional check when resolving identity from did * tidy * Reject did documents containing invalid `alsoKnownAs` ATProto handles * Use error classes * tidy * Improve identity resolution * tidy * Allow non-normalized handles in did document * pnpm-lock * Version packages (#3979) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * repo: MST should allow tilde in keys (#3981) * repo: MST should allow tilde in keys * add changeset * fic ci * tidy * tidy --------- Co-authored-by: rafael <rafael@blueskyweb.xyz> Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: James Futhey <kidGodzilla@users.noreply.github.com> Co-authored-by: bnewbold <bnewbold@robocracy.org> Co-authored-by: Samuel Newman <mozzius@protonmail.com> Co-authored-by: leopardracer <136604165+leopardracer@users.noreply.github.com> Co-authored-by: devin ivy <devinivy@gmail.com> Co-authored-by: Paul Frazee <pfrazee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.