Remove scenes #483
Merged
Remove scenes #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Jan 24, 2023
| @@ -14,15 +14,7 @@ export default function (server: Server, ctx: AppContext) { | |||
| server.app.bsky.actor.updateProfile({ | |||
| auth: ctx.accessVerifierCheckTakedown, | |||
| handler: async ({ auth, input }) => { | |||
| const requester = auth.credentials.did | |||
|
|
|||
| const did = input.body.did || requester | |||
There was a problem hiding this comment.
Would not mind getting rid of these did inputs! I don't think we have a use for them now, and I think we sort of want to redesign that bit of auth anyway next time we come across the same use-case.
There was a problem hiding this comment.
ah yeah that's not a bad idea.
would clean things up & they're the type of param we can add in later (or solve w the auth system)
devinivy
approved these changes
Jan 24, 2023
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* wip * wip * remove getAssertions & fix up notifs test * remove did param on updateProfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing scenes & trends from the PDS.
This also removes the views for getAssertions & getMembers(hips) along with notifications for assertions, however it leaves behind the lexicons for assertion & confirmation records. I'm not opposed to removing those also, but they seem like the most likely candidate to be worked back in soon.
For those listening in: Scenes will be making a comeback! However at the current moment they're a little half-baked & we want to be sure to flesh out the concept a bit before committing to it feature-wise
Not included in this PR:
Have plans to do those in a subsequent PR shortly