-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow login using email #492
Conversation
Okay I'm +1 to this solution. Your approach to the lexicon approach is right for published schemas but I think because this isn't published yet, what we can do instead is:
|
@pfrazee one minor detail to confirm— I believe we will need to leave |
@devinivy Ah yes, you're quite right. |
Alright, that should be patched-up! Created #493 to track the deprecation of |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool cool 👌
* Allow login using email, deprecate handle input in session.create * Remove handle input from session.create lexicon
This allow users to create a session using their email address (in addition to their handle). I marked session.create's
handle
input as deprecated and added an optionalidentifier
input— the PDS should be free to establish any identifier it wants with its users in addition to their handle.