Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow login using email #492

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Allow login using email #492

merged 2 commits into from
Jan 26, 2023

Conversation

devinivy
Copy link
Collaborator

@devinivy devinivy commented Jan 26, 2023

This allow users to create a session using their email address (in addition to their handle). I marked session.create's handle input as deprecated and added an optional identifier input— the PDS should be free to establish any identifier it wants with its users in addition to their handle.

@pfrazee
Copy link
Collaborator

pfrazee commented Jan 26, 2023

Okay I'm +1 to this solution. Your approach to the lexicon approach is right for published schemas but I think because this isn't published yet, what we can do instead is:

  • Just switch the lexicon to identifier and drop handle entirely
  • In the PDS code, still check for handle. Open an issue to drop that in a month(?) and comment with the issue number

@devinivy
Copy link
Collaborator Author

@pfrazee one minor detail to confirm— I believe we will need to leave identifier optional for the time being. Then when we stop checking for handle in a month, it should become required. So technically you will be able to send a valid payload that looks like { password }, and it will just behave like you gave a bad identifier/password combo.

@pfrazee
Copy link
Collaborator

pfrazee commented Jan 26, 2023

@devinivy Ah yes, you're quite right.

@devinivy
Copy link
Collaborator Author

Alright, that should be patched-up! Created #493 to track the deprecation of handle.

@pfrazee
Copy link
Collaborator

pfrazee commented Jan 26, 2023

LGTM!

Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool cool 👌

@devinivy devinivy merged commit 9834c2f into main Jan 26, 2023
@devinivy devinivy deleted the login-w-email branch January 26, 2023 18:08
@devinivy devinivy mentioned this pull request Jan 26, 2023
mloar pushed a commit to mloar/atproto that referenced this pull request Nov 15, 2023
* Allow login using email, deprecate handle input in session.create

* Remove handle input from session.create lexicon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants