Delete blobs app migration #963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
May 8, 2023
Comment on lines
80
to
81
| async function derefedProfiles(dbTxn: Database) { | ||
| dbTxn.assertTransaction() |
There was a problem hiding this comment.
We might find this is heavy for a single transaction. If that's an issue, even just doing it in batches by did might do the trick.
There was a problem hiding this comment.
Do you think we even need to use transactions here?
I actually don't see much that needs to be done transactionally in this 🤔
devinivy
approved these changes
May 8, 2023
|
successfully ran this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off of #959
Deleting all currently dereferenced blobs
Test & code for this do not need to be merged in, just ran