Auditability #4
Merged
Auditability #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Feb 28, 2023
| @@ -78,6 +78,6 @@ describe('compatibility', () => { | |||
|
|
|||
| const result = await assureValidNextOp(did, [indexedLegacy], nextOp) | |||
| expect(result.nullified.length).toBe(0) | |||
| expect(result.prev?.equals(legacyCid)) | |||
| expect(result.prev?.equals(legacyCid)).toBeTruthy() | |||
devinivy
reviewed
Feb 28, 2023
devinivy
reviewed
Feb 28, 2023
| @@ -48,7 +53,7 @@ export const createRouter = (ctx: AppContext): express.Router => { | |||
| }) | |||
|
|
|||
| // Get data for a DID document | |||
| router.get('/data/:did', async function (req, res) { | |||
| router.get('/:did/data', async function (req, res) { | |||
There was a problem hiding this comment.
👍 Big +1 on these changes!
devinivy
reviewed
Feb 28, 2023
packages/server/src/routes.ts
Outdated
Comment on lines
79
to
80
| // Get operation log for a DID | ||
| router.get('/:did/auditable', async function (req, res) { |
There was a problem hiding this comment.
I don't want to overthink this name, but the fact that it's an adjective and the rest are nouns sort of piqued my attention. Only other idea I can think of is /:did/log/audit.
There was a problem hiding this comment.
good point
honestly maybe just /:did/audit
devinivy
reviewed
Feb 28, 2023
packages/server/src/routes.ts
Outdated
| }) | ||
|
|
||
| // Get the most recent operation in the log for a DID | ||
| router.get('/last/:did', async function (req, res) { | ||
| router.get('/:did/last', async function (req, res) { |
There was a problem hiding this comment.
In a similar line of thought re: /:did/log/audit, I could also imagine calling this /:did/log/last. Really not too hung-up on it, really just one final poke to make sure we like the naming conventions here!
There was a problem hiding this comment.
actually you're right i'll do those 👍
devinivy
approved these changes
Feb 28, 2023
Co-authored-by: devin ivy <devinivy@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new routes
/exportwhich exports the entire PLC database as a series of jsonlines, where each line is an operation ordered bycreatedAttime. This is paginated with a limit of 1000 lines per req/:did/auditablewhich gives the auditable log for a user that includes timestamps & nullified operations