Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full domain to add TXT for in handle update modal #1087

Closed
alimony opened this issue Aug 2, 2023 · 3 comments · Fixed by #1245
Closed

Show full domain to add TXT for in handle update modal #1087

alimony opened this issue Aug 2, 2023 · 3 comments · Fixed by #1245
Assignees
Labels
feature-request A request for a new feature x:discussing We've seen the request and we're talking about it!

Comments

@alimony
Copy link
Contributor

alimony commented Aug 2, 2023

When setting a custom domain handle, the ”well-known” method tab updates with the domain name you enter which makes the instructions very clear. But for the DNS method tab, it just says to add a TXT for ”_atproto” regardless of what you typed in the handle field. I think it would be more user-friendly and clear to display the full domain name in the instructions. It would reduce confusion especially when setting a subdomain handle. Essentially, it’s probably clearer to say add this TXT record for ”_atproto.my.domain.com” than just ”_atproto”.

@alimony alimony added the feature-request A request for a new feature label Aug 2, 2023
@pfrazee
Copy link
Collaborator

pfrazee commented Aug 2, 2023

@alimony That is originally what we did but people would frequently copy the value as given into their settings panel, leading them to register _atproto.bob.com.bob.com instead of _atproto.bob.com. I've received far fewer support requests since making this change.

@pfrazee pfrazee added the x:discussing We've seen the request and we're talking about it! label Aug 2, 2023
@alimony
Copy link
Contributor Author

alimony commented Aug 2, 2023

Interesting piece of real-world data! Maybe updating the paragraph above it to be more explicit could help:

Screenshot 2023-08-02 at 22 14 37 Screenshot 2023-08-02 at 22 15 07

Maybe also add a link in there somewhere to the documentation on custom handles, which also someone said isn't super clear on subdomains.

@pfrazee pfrazee self-assigned this Aug 15, 2023
@pfrazee
Copy link
Collaborator

pfrazee commented Aug 22, 2023

Proposing this in a PR, we'll see if it passes review:

CleanShot 2023-08-21 at 19 40 54@2x

pfrazee added a commit that referenced this issue Aug 22, 2023
* Remove potentially confusing period from subdomain in changehandle (close #1004)

* Clarify dns instructions further (close #1087)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for a new feature x:discussing We've seen the request and we're talking about it!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants