Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] When closing the Google Translate screen, it does not return to the previously opened screen. #6741

Closed
nnabeyang opened this issue Nov 26, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@nnabeyang
Copy link
Contributor

nnabeyang commented Nov 26, 2024

Steps to Reproduce

  1. Launch the app and open the timeline or feed.
  2. Open a thread with a post written in a language different from the one set as Primary Language.
  3. Tap the Translate button to open the Google Translate screen.
  4. Tap Done in the top left corner of the screen.

Attachments

video.mp4

What platform(s) does this occur on?

iOS

Device Info

iPhone 14 Pro

What version of the app are you using?

Build version: 1.94.0.602; Bundle info: 3c30bb1 (prod); Bundle date: 24111623; Platform: ios; Platform version: 18.1.1

Additional Information

No response

@nnabeyang nnabeyang added the bug Something isn't working label Nov 26, 2024
@surfdude29
Copy link
Contributor

This should be fixed by #6657 which will be in 1.95, hopefully available within the next few days.

As a workaround until the new version is released, try using the Translate option in the post context menu. That doesn't seem to trigger the bug.

@nnabeyang
Copy link
Contributor Author

@surfdude29
Since version 1.95 of the iOS app is not yet available, I would like to wait until it's released and verify that the issue is resolved before closing this issue. Would that be okay with you?

I’m not entirely familiar with how issues are handled in this project. If the Bluesky team usually handles closing issues, I don’t mind if you go ahead and close it.

@surfdude29
Copy link
Contributor

Since version 1.95 of the iOS app is not yet available, I would like to wait until it's released and verify that the issue is resolved before closing this issue. Would that be okay with you?

@nnabeyang Of course, that's totally fine, I just wanted to let you know what the status was and that it should be fixed soon :)

I’m not entirely familiar with how issues are handled in this project. If the Bluesky team usually handles closing issues, I don’t mind if you go ahead and close it.

To be clear, I'm just a volunteer contributor, so I can't close other people's issues in any case 😅

@nnabeyang
Copy link
Contributor Author

@surfdude29
Got it, thank you for the clarification.

@auroursa
Copy link
Contributor

I have conducted initial tests on Android and iOS, and the translation feature works well after this PR. But hey, I agree that we should perform a secondary confirmation after the official release.

As a temporary workaround, you might want to try this.

@nnabeyang
Copy link
Contributor Author

I have confirmed that the bug has been fixed in version 1.95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants