Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement embed cards - so they show content #724

Closed
ianklatzco opened this issue May 17, 2023 · 4 comments
Closed

Implement embed cards - so they show content #724

ianklatzco opened this issue May 17, 2023 · 4 comments
Labels
feature-request A request for a new feature x:discussing We've seen the request and we're talking about it!

Comments

@ianklatzco
Copy link

ianklatzco commented May 17, 2023 •
edited
Loading

I'd like to stop maintaining psky.app at some point, so interested in #609 -- just needs HTTP routes.
@ianklatzco ianklatzco added the feature-request A request for a new feature label May 17, 2023
@ianklatzco ianklatzco mentioned this issue May 17, 2023
Open
@bnewbold
Copy link
Contributor

these seem to be mostly working? at least in, eg, signal

@ianklatzco
Copy link
Author

they don't actually show post content
image

@ianklatzco ianklatzco changed the title Implement embed cards Implement embed cards - so they show content May 18, 2023
@ianklatzco
Copy link
Author

And in Discord, they're only working sometimes:

image

https://discord.com/channels/1097580399187738645/1097580399187738648/1108602956602945607

image

https://discord.com/channels/1097580399187738645/1097580399187738648/1108725030352867349

@pfrazee pfrazee added the x:discussing We've seen the request and we're talking about it! label May 19, 2023
@ianklatzco
Copy link
Author

ianklatzco commented May 26, 2023 •
edited
Loading

They seem to work now in Discord & Telegram -- maybe I just caught it in the deploy window.

Maybe this means I can kill psky!

There are still some funny/suboptimal behaviors.

Discord & Telegram are not rendering 4 images, even though they can. Emulating Twitter's behavior would be ideal.

@ianklatzco ianklatzco mentioned this issue May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A request for a new feature x:discussing We've seen the request and we're talking about it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bnewbold @pfrazee @ianklatzco