Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner aspect ratio can not be changed on Linux/Firefox #760

Closed
smoyer64 opened this issue May 19, 2023 · 11 comments · Fixed by #3735
Closed

Banner aspect ratio can not be changed on Linux/Firefox #760

smoyer64 opened this issue May 19, 2023 · 11 comments · Fixed by #3735
Assignees
Labels
bug Something isn't working x:planned We're on it!

Comments

@smoyer64
Copy link

Describe the bug

On Firefox (Linux) 114.0b4, there is no way to change the aspect ration of a banner image.

To Reproduce

Steps to reproduce the behavior:

  1. Attempt to load an image suitable for a banner (say 3:1).

Expected behavior

I expected to be able to change the aspect ratio. On Chromium (Linux), there are in fact three buttons but the horizontal and vertical aspect ratios provide very slight changes from a plain square. In the Android app, loading the same image results in the expected banner orientation (though my banner is a bit too large and does in fact get clippted

Screenshots

bluesky-banner-square-linux-20230519

Details

  • Platform: Xubuntu Linux with the latest Firefox and Chromium
  • Platform version: 22.04
  • App version: Build version TODO (TODO)
@smoyer64 smoyer64 added the bug Something isn't working label May 19, 2023
@pfrazee
Copy link
Collaborator

pfrazee commented Jun 6, 2023

Ah, yes indeed this is not the right behavior

@pfrazee
Copy link
Collaborator

pfrazee commented Jun 6, 2023

The cropper should be in the correct aspect ratio for the banner

@pfrazee pfrazee added the x:planned We're on it! label Jun 6, 2023
@wrthfl
Copy link

wrthfl commented Jul 3, 2023

This is an issue on Windows too.
Firefox 114.0.2 (64-Bit)

@mschwendener
Copy link

I used Chrome on Mac when I signed up a few days ago (because it seemed to work better than Firefox), but it's not behaving yet as it should.

@mschwendener
Copy link

@pfrazee pfrazee self-assigned this Aug 15, 2023
@mschwendener
Copy link

mschwendener commented Oct 11, 2023

Uploading / replacing the banner picture should have a cropping option that fits with the banner picture dimensions.

screenshot_4597

v2

@mschwendener
Copy link

At least let me open somebody's banner picture in a new tab so I can see what's on it?

screenshot_4715

@nicole-ashley
Copy link

nicole-ashley commented Feb 3, 2024

@pfrazee This is an issue in the profile picture cropper too (at least on Android): it requires you to fill the aspect ratio of the uploaded image rather than the actual square crop (meaning you have to zoom in to crop anywhere other than centre).

@mschwendener
Copy link

Adding a banner picture still doesn't work as it should. What are the dimenstions my picture needs so it is displayed as I intent?

20240305

@piotrpalek
Copy link
Contributor

Is this something that I could try to work on if I want to try my hand at hacking on the bluesky app or is it already WIP internally?

@pfrazee
Copy link
Collaborator

pfrazee commented Apr 22, 2024

Is this something that I could try to work on if I want to try my hand at hacking on the bluesky app or is it already WIP internally?

Actually this would be a great one to hit, it's not on our TODOs and pretty straightforward in its scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working x:planned We're on it!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants