-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Banner aspect ratio can not be changed on Linux/Firefox #760
Comments
Ah, yes indeed this is not the right behavior |
The cropper should be in the correct aspect ratio for the banner |
This is an issue on Windows too. |
I used Chrome on Mac when I signed up a few days ago (because it seemed to work better than Firefox), but it's not behaving yet as it should. |
@pfrazee This is an issue in the profile picture cropper too (at least on Android): it requires you to fill the aspect ratio of the uploaded image rather than the actual square crop (meaning you have to zoom in to crop anywhere other than centre). |
Is this something that I could try to work on if I want to try my hand at hacking on the bluesky app or is it already WIP internally? |
Actually this would be a great one to hit, it's not on our TODOs and pretty straightforward in its scope |
Describe the bug
On Firefox (Linux) 114.0b4, there is no way to change the aspect ration of a banner image.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expected to be able to change the aspect ratio. On Chromium (Linux), there are in fact three buttons but the horizontal and vertical aspect ratios provide very slight changes from a plain square. In the Android app, loading the same image results in the expected banner orientation (though my banner is a bit too large and does in fact get clippted
Screenshots
Details
The text was updated successfully, but these errors were encountered: