Posts containing only an image do not show in custom feeds

[strideynet]

Expected behaviour

A post containing an image but no text (e.g someone posting a meme) should show up on custom feeds (previously on "goodstuff") when a user has a configured preferred language.

Reproduction

1. Have a preferred language configured
2. Make a post containing only an image
3. Have this post be popular enough to show on goodstuff or on the custom feeds branch go to a custom feed you know should show this post
4. Observe the lack of the post showing

Actual behaviour

These posts are filtered out by the client and do not render.

Details

• Platform: Web
• Platform version: Observed most recently at commit e891039

Guess at cause

preferredLangOnly tuner contains the following if statement:

          if (
            hasProp(item.post.record, 'text') &&
            typeof item.post.record.text === 'string'
          ) {
            const res = lande(item.post.record.text)
            console.log(res)
            if (langsCode3.includes(res[0][0])) {
              hasPreferredLang = true
              break
            }
          } else {
            // no text? roll with it
            hasPreferredLang = true
            break
          }

This is missing an additional check to ensure that item.post.record.text is not an empty string.

[pfrazee]

We plan to change language detection to be declared on the post by the author so that this isn't an issue anymore.

[strideynet]

Closed by #871