Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling issues in components on webpage #948

Closed
notJoon opened this issue Jul 3, 2023 · 3 comments
Closed

Scrolling issues in components on webpage #948

notJoon opened this issue Jul 3, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@notJoon
Copy link

notJoon commented Jul 3, 2023

Describe the bug
There is an scrolling issue within certain components on Bluesky web page for screens that are 900x700 pixels or smaller. When scrolling is initiated within these components (home or search), the entire screen scrolls insted, resulting in a white blank space at the end of the screen.

To Reproduce

Steps to reproduce the behavior:

  1. Open the web page with size 900x700 pixels or less
  2. Try scrolling within any component other than the Timeline
  3. Observe that the whole page scrolls instead of the timeline component, resulting in a white screent at the side

Expected behavior

When a user scrolls within any given component, only the post(timeline) should be scrolled. The whole page must not move along with it. This behavior should be consistent, regardless of the screen size.

Screenshots

2023-07-03.11.33.16.mov

Details

  • Platform: desktop Firefox browser
  • Platform version: 114.0.2
  • App version: build version 1.37.0

Additional context

I think that the issue might be related to certain constants within the useMainScroll function. The constants DY_LIMIT_DOWN, DY_LIMIT_UP and s.window.height may not be properly accommodating the scrollable height of certain components or the specific screen sizes where the issue occurs.

@notJoon notJoon added the bug Something isn't working label Jul 3, 2023
@ansh
Copy link
Contributor

ansh commented Jul 20, 2023

Can you try refreshing the page after you change the window size and check if it still occurs? @notJoon

@notJoon
Copy link
Author

notJoon commented Jul 20, 2023

Looks like it's fixed now @ansh

@pfrazee
Copy link
Collaborator

pfrazee commented Jul 24, 2023

Good deal. This kind of bug is kind of easy to have surface with our current layout system so if it happens again, please let us know

@pfrazee pfrazee closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants