Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logged out metadata on posts and profiles is currently broken #975

Open
Jonty opened this issue Jul 5, 2023 · 7 comments
Open

Logged out metadata on posts and profiles is currently broken #975

Jonty opened this issue Jul 5, 2023 · 7 comments
Assignees
Labels
bug Something isn't working x:planned We're on it!

Comments

@Jonty
Copy link
Contributor

Jonty commented Jul 5, 2023

Describe the bug

Logged out metadata about posts and profiles is currently broken.

The main page tags exist but are empty. The meta tags are missing due to postView being null.

To Reproduce

Steps to reproduce the behavior:

curl https://bsky.app/profile/bsky.app/post/3jzpikdls2z23 | grep bsky_
    <p id="bsky_display_name"></p>
    <p id="bsky_handle"></p>
    <p id="bsky_did"></p>
    <p id="bsky_post_text"></p>
curl https://bsky.app/profile/bsky.app | grep bsky_
    <p id="bsky_display_name"></p>
    <p id="bsky_handle"></p>
    <p id="bsky_did"></p>
    <p id="bsky_profile_description"></p>

Expected behavior

The tags are populated, and the <meta> tags are added to the page and populated.

Additional context

I suspect this may be due to the Go server in production having expired API credentials, so is unable to fetch the post/profile data.

@Jonty Jonty added the bug Something isn't working label Jul 5, 2023
@pfrazee
Copy link
Collaborator

pfrazee commented Jul 5, 2023

@Jacob2161 can you double check this for me? <3

@pfrazee pfrazee added the x:planned We're on it! label Jul 5, 2023
@Jonty
Copy link
Contributor Author

Jonty commented Jul 6, 2023

This now appears to be fixed, however a bug means the post text is missing on the server-side generated post page. I have filed a PR to fix this: #981

@Jonty
Copy link
Contributor Author

Jonty commented Jul 7, 2023

And, it's now broken again! 😭

@Jonty
Copy link
Contributor Author

Jonty commented Jul 7, 2023

This looks related to #983

@Jacob2161
Copy link
Contributor

Yeah, this is broken and always has been I believe. I have a fix to refresh the token and will try to test it out and get it up today.

@Jonty
Copy link
Contributor Author

Jonty commented Nov 6, 2023

This was fixed by #1065

@Jonty Jonty closed this as completed Nov 6, 2023
@Jonty Jonty reopened this Feb 28, 2024
@Jonty
Copy link
Contributor Author

Jonty commented Feb 28, 2024

Well, it's broken again! I can't see an obvious code change that has broken it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working x:planned We're on it!
Projects
None yet
Development

No branches or pull requests

3 participants