Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update icons.tsx - Simplify SatelliteDishIcon paths #1048

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Update icons.tsx - Simplify SatelliteDishIcon paths #1048

merged 1 commit into from
Jul 25, 2023

Conversation

DavidBuchanan314
Copy link
Contributor

@DavidBuchanan314 DavidBuchanan314 commented Jul 24, 2023 •
edited
Loading

This prevents rendering jank

Before: (as rendered by Firefox)

image

After:

image

See also: https://bsky.app/profile/spacefag.bsky.social/post/3k3bomsmzrr2r

ansh
ansh approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@ansh ansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Thanks!

@pfrazee
Copy link
Collaborator

pfrazee commented Jul 25, 2023

Tested on ios, android, ff and chrome. Looks good!

@pfrazee
Copy link
Collaborator

pfrazee commented Jul 25, 2023

Thanks david!

@pfrazee pfrazee merged commit 44b3929 into bluesky-social:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansh ansh ansh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidBuchanan314 @pfrazee @ansh